From: Alan Cox <alan@lxorguk•ukuu.org.uk>
To: Wang YanQing <udknight@gmail•com>
Cc: Randy Dunlap <rdunlap@xenotime•net>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Michal Januszewski <spock@gentoo•org>,
Florian Tobias Schandinat <FlorianSchandinat@gmx•de>,
linux-fbdev@vger•kernel.org, x86@kernel•org,
Andrew Morton <akpm@linux-foundation•org>,
tglx@linutronix•de, mingo@redhat•com, hpa@zytor•com
Subject: Re: [PATCH v2] x86: export 'pcibios_enabled' as GPL
Date: Wed, 21 Mar 2012 09:29:50 +0000 [thread overview]
Message-ID: <20120321092950.7fc07d84@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <20120321043721.GA927@udknight>
On Wed, 21 Mar 2012 12:37:21 +0800
Wang YanQing <udknight@gmail•com> wrote:
> On Sun, Mar 18, 2012 at 06:03:41PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@xenotime•net>
> >
> > Export 'pcibios_enabled' so that when uvesafb is built as a
> > loadable module (on X86_32), the build will succeed.
> >
> > ERROR: "pcibios_enabled" [drivers/video/uvesafb.ko] undefined!
> >
> > Patch v2 uses EXPORT_SYMBOL_GPL() as requested.
> >
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime•net>
> > Cc: Michal Januszewski <spock@gentoo•org>
> > Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx•de>
> > Cc: linux-fbdev@vger•kernel.org
> > Cc: x86@kernel•org
> > ---
> > arch/x86/pci/pcbios.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- linux-next-20120313.orig/arch/x86/pci/pcbios.c
> > +++ linux-next-20120313/arch/x86/pci/pcbios.c
> > @@ -27,6 +27,7 @@
> > #define PCIBIOS_HW_TYPE2_SPEC 0x20
> >
> > int pcibios_enabled;
> > +EXPORT_SYMBOL_GPL(pcibios_enabled);
> >
> > /* According to the BIOS specification at:
> > * http://members.datafast.net.au/dft0802/specs/bios21.pdf, we could
> Acked-by: Wang YanQing <udknight@gmail•com>
NAKked again by Alan Cox <alan@linux•intel.com>
The fb code shouldn't be playing guessing games with thsi variable.
I've pointed out both how to check if NX is enabled and how to set pages
NX/non-NX.
Even if you wanted to check the pci bios state we should export a helper
method.
So NAK.
Alan
next prev parent reply other threads:[~2012-03-21 9:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 9:41 linux-next: Tree for Mar 13 Stephen Rothwell
2012-03-13 17:10 ` linux-next: Tree for Mar 13 (dlm / gfs2) Randy Dunlap
2012-03-13 20:30 ` [PATCH] x86: export 'pcibios_enabled' Randy Dunlap
2012-03-14 0:43 ` H. Peter Anvin
2012-03-14 9:29 ` Alan Cox
2012-03-14 10:59 ` Florian Tobias Schandinat
2012-03-14 11:21 ` Alan Cox
2012-03-22 0:41 ` Wang YanQing
2012-03-26 0:27 ` Wang YanQing
2012-03-16 0:41 ` Wang YanQing
2012-03-19 0:30 ` Wang YanQing
2012-03-19 1:03 ` [PATCH v2] x86: export 'pcibios_enabled' as GPL Randy Dunlap
2012-03-21 4:37 ` Wang YanQing
2012-03-21 9:29 ` Alan Cox [this message]
2012-03-13 21:06 ` linux-next: Tree for Mar 13 (ata) Randy Dunlap
2012-03-13 21:22 ` Jeff Garzik
2012-03-14 0:36 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321092950.7fc07d84@pyramind.ukuu.org.uk \
--to=alan@lxorguk$(echo .)ukuu.org.uk \
--cc=FlorianSchandinat@gmx$(echo .)de \
--cc=akpm@linux-foundation$(echo .)org \
--cc=hpa@zytor$(echo .)com \
--cc=linux-fbdev@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@redhat$(echo .)com \
--cc=rdunlap@xenotime$(echo .)net \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=spock@gentoo$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=udknight@gmail$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox