From: Wim Van Sebroeck <wim@iguana•be>
To: Randy Dunlap <rdunlap@xenotime•net>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
linux-watchdog@vger•kernel.org
Subject: Re: [PATCH -next] via_wdt: depends on PCI
Date: Mon, 14 May 2012 15:14:54 +0200 [thread overview]
Message-ID: <20120514131454.GG3074@spo001.leaseweb.com> (raw)
In-Reply-To: <4FADA2B2.8070302@xenotime.net>
Hello Rancy,
> From: Randy Dunlap <rdunlap@xenotime•net>
>
> via_wdt is a PCI driver so it should depend on PCI so that
> it will not cause build errors.
>
> drivers/watchdog/via_wdt.c:256:1: warning: data definition has no type or storage class
> drivers/watchdog/via_wdt.c:256:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
> drivers/watchdog/via_wdt.c:256:1: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime•net>
Fix added.
Thanks,
Wim.
next prev parent reply other threads:[~2012-05-14 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 6:27 linux-next: Tree for May 11 Stephen Rothwell
2012-05-11 23:19 ` linux-next: Tree for May 11 (printk) Randy Dunlap
2012-05-11 23:36 ` [PATCH -next] printk: add stub for prepend_timestamp() Randy Dunlap
2012-05-11 23:37 ` [PATCH -next] via_wdt: depends on PCI Randy Dunlap
2012-05-14 13:14 ` Wim Van Sebroeck [this message]
2012-05-11 23:52 ` linux-next: Tree for May 11 (perf_event_amd.c) Randy Dunlap
2012-05-12 1:33 ` [PATCH -next] watchdog: fix ie6xx_wdt.c printk format warning Randy Dunlap
2012-05-14 13:15 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514131454.GG3074@spo001.leaseweb.com \
--to=wim@iguana$(echo .)be \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=rdunlap@xenotime$(echo .)net \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox