From: Stephen Rothwell <sfr@canb•auug.org.au>
To: David Rientjes <rientjes@google•com>
Cc: LKML <linux-kernel@vger•kernel.org>,
linux-next@vger•kernel.org,
ppc-dev <linuxppc-dev@lists•ozlabs.org>,
Thomas Gleixner <tglx@linutronix•de>, Ingo Molnar <mingo@elte•hu>,
"H. Peter Anvin" <hpa@zytor•com>,
Peter Zijlstra <peterz@infradead•org>,
Lee Schermerhorn <lee.schermerhorn@hp•com>,
Linus <torvalds@linux-foundation•org>
Subject: Re: linux-next: PowerPC boot failures in next-20120521
Date: Tue, 22 May 2012 13:03:54 +1000 [thread overview]
Message-ID: <20120522130354.fdb335eb294f4206b4b2fed5@canb.auug.org.au> (raw)
In-Reply-To: <alpine.DEB.2.00.1205211846120.20916@chino.kir.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
Hi David,
On Mon, 21 May 2012 18:53:37 -0700 (PDT) David Rientjes <rientjes@google•com> wrote:
>
> Yeah, it's sched/numa since that's what introduced numa_init(). It does
> for_each_node() for each node and does a kmalloc_node() even though that
> node may not be online. Slub ends up passing this node to the page
> allocator through alloc_pages_exact_node(). CONFIG_DEBUG_VM would have
> caught this and your config confirms its not enabled.
>
> sched/numa either needs a memory hotplug notifier or it needs to pass
> NUMA_NO_NODE for nodes that aren't online. Until we get the former, the
> following should fix it.
>
>
> sched, numa: Allocate node_queue on any node for offline nodes
>
> struct node_queue must be allocated with NUMA_NO_NODE for nodes that are
> not (yet) online, otherwise the page allocator has a bad zonelist.
>
> Signed-off-by: David Rientjes <rientjes@google•com>
Thanks, that fixes it.
Tested-by: Stephen Rothwell <sfr@canb•auug.org.au>
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-22 3:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 1:40 linux-next: PowerPC boot failures in next-20120521 Stephen Rothwell
2012-05-22 1:53 ` David Rientjes
2012-05-22 3:03 ` Stephen Rothwell [this message]
2012-05-22 3:25 ` Stephen Rothwell
2012-05-23 4:17 ` [patch] sched, numa: Allocate node_queue on any node for offline nodes David Rientjes
2012-05-22 2:12 ` linux-next: PowerPC boot failures in next-20120521 Michael Neuling
2012-05-22 2:25 ` David Rientjes
2012-05-22 2:39 ` Michael Neuling
2012-05-22 2:40 ` Michael Neuling
2012-05-22 2:44 ` David Rientjes
2012-05-22 2:51 ` Michael Neuling
2012-05-22 2:58 ` David Rientjes
2012-05-22 3:12 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120522130354.fdb335eb294f4206b4b2fed5@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=hpa@zytor$(echo .)com \
--cc=lee.schermerhorn@hp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@elte$(echo .)hu \
--cc=peterz@infradead$(echo .)org \
--cc=rientjes@google$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox