From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: Geert Uytterhoeven <geert@linux-m68k•org>
Cc: "Bjørn Mork" <bjorn@mork•no>,
"USB list" <linux-usb@vger•kernel.org>,
linux-kernel@vger•kernel.org,
Linux-Next <linux-next@vger•kernel.org>,
linux-kbuild <linux-kbuild@vger•kernel.org>,
Linux/m68k <linux-m68k@vger•kernel.org>
Subject: Re: [-next] FATAL: drivers/gpu/drm/udl/udl: sizeof(struct usb_device_id)=24 is not a modulo of the size of section __mod_usb_device_table=44.
Date: Fri, 15 Jun 2012 13:10:21 -0700 [thread overview]
Message-ID: <20120615201021.GB14544@kroah.com> (raw)
In-Reply-To: <CAMuHMdXk6pByz14JcDgY+UE6QM0sHD8cbXye9CgOVSRRtr7J+Q@mail.gmail.com>
On Fri, Jun 15, 2012 at 07:42:08PM +0200, Geert Uytterhoeven wrote:
> commit 81df2d594340dcb6d1a02191976be88a1ca8120c ("USB: allow match
> on bInterfaceNumber") added a byte to the interior of struct usb_device_id,
> enabling implicit padding:
>
> --- a/include/linux/mod_devicetable.h
> +++ b/include/linux/mod_devicetable.h
> @@ -115,6 +118,9 @@ struct usb_device_id {
> __u8 bInterfaceSubClass;
> __u8 bInterfaceProtocol;
>
> + /* Used for vendor-specific interface matches */
> + __u8 bInterfaceNumber;
> +
> /* not matched against */
> kernel_ulong_t driver_info;
> };
>
> On m68k, this causes failures like:
>
> | FATAL: drivers/gpu/drm/udl/udl: sizeof(struct usb_device_id)=24 is
> not a modulo of the size of section __mod_usb_device_table=44.
> | Fix definition of struct usb_device_id in mod_devicetable.h
>
> M68k is special in that it uses 2 for the alignment of 32-bit entities, hence
> sizeof(struct usb_device_id) = 22.
>
> However, when cross-compiling on amd64, sizeof(struct usb_device_id) = 24
> in scripts/mod/file2alias.c.
I don't really understand, what is the problem here? The fact that we
added one byte to the structure? And now something breaks? How?
What can we do to resolve it?
confused,
greg k-h
next prev parent reply other threads:[~2012-06-15 20:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 17:42 [-next] FATAL: drivers/gpu/drm/udl/udl: sizeof(struct usb_device_id)=24 is not a modulo of the size of section __mod_usb_device_table=44 Geert Uytterhoeven
2012-06-15 20:10 ` Greg Kroah-Hartman [this message]
[not found] ` <20120615201021.GB14544-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-06-15 21:02 ` Geert Uytterhoeven
2012-06-15 23:12 ` Greg Kroah-Hartman
2012-06-16 13:23 ` Bjørn Mork
2012-06-16 15:43 ` Andreas Schwab
2012-06-17 14:00 ` Bjørn Mork
2012-06-17 15:42 ` Andreas Schwab
2012-06-25 12:22 ` [PATCH] mod/file2alias: make modalias generation safe for cross compiling Andreas Schwab
[not found] ` <m2d34n1sz9.fsf_-_-hBGjKatGTSWzQB+pC5nmwQ@public.gmane.org>
2012-06-25 20:32 ` Geert Uytterhoeven
[not found] ` <alpine.DEB.2.00.1206252217580.21346-97SZ98TBZzA1xEWliksxXw@public.gmane.org>
2012-06-25 21:43 ` Andreas Schwab
2012-06-26 5:00 ` Sam Ravnborg
2012-06-26 13:27 ` [PATCH v2] " Andreas Schwab
2012-06-16 18:33 ` [-next] FATAL: drivers/gpu/drm/udl/udl: sizeof(struct usb_device_id)=24 is not a modulo of the size of section __mod_usb_device_table=44 Philippe De Muyter
2012-06-16 19:11 ` Greg Kroah-Hartman
2012-06-16 19:30 ` Geert Uytterhoeven
2012-06-16 18:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615201021.GB14544@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=bjorn@mork$(echo .)no \
--cc=geert@linux-m68k$(echo .)org \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox