From: Sam Ravnborg <sam@ravnborg•org>
To: Geert Uytterhoeven <geert@linux-m68k•org>
Cc: linux-kbuild <linux-kbuild@vger•kernel.org>,
Avi Kivity <avi@redhat•com>,
Paul Gortmaker <paul.gortmaker@windriver•com>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Linux/m68k <linux-m68k@vger•kernel.org>,
kvm@vger•kernel.org, Paul Mundt <lethal@linux-sh•org>
Subject: Re: asm/kvm_para.h from asm-generic (was: Re: linux-next: triage for April 19, 2012)
Date: Tue, 19 Jun 2012 21:00:08 +0200 [thread overview]
Message-ID: <20120619190008.GA11092@merkur.ravnborg.org> (raw)
In-Reply-To: <20120619184803.GA31656@merkur.ravnborg.org>
On Tue, Jun 19, 2012 at 08:48:03PM +0200, Sam Ravnborg wrote:
> > >>
> > >> I just noticed include/asm-generic/Kbuild.asm already had
> > >>
> > >> ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h \
> > >> $(srctree)/include/asm-$(SRCARCH)/kvm_para.h),)
> > >> header-y += kvm_para.h
> > >> endif
> > >>
> > >> but this doesn't seem to work.
> > >>
> > >> Kbuild people: which one is correct?
>
> Any use of wildcards in include/asm-generic/Kbuild.asm is bogus.
> We should:
> 1) add explicit header-y for kvm.h + a.out.h to the relevant architectures.
> 2) add explicit header-y for kvm_para.h for the archictectures that needs this file
> 3) and drop header-y / dummy file fro the others.
>
> Anything else is just papering over the initial wrong doings.
>
> I actually coded up "header-n" support to explicitly say:
> do not include this file for this arch - but looking at the
> actual problem being solved this is just bogus so I killed
> it off again.
Just to be clear - I know this will break headers_check_all.
I will try to take a look soon for a better generic solution.
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger•kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-06-19 19:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 21:07 asm/kvm_para.h from asm-generic (was: Re: linux-next: triage for April 19, 2012) Geert Uytterhoeven
2012-06-13 12:46 ` Geert Uytterhoeven
2012-06-13 12:49 ` Geert Uytterhoeven
2012-06-14 3:29 ` Paul Mundt
2012-06-19 18:48 ` Sam Ravnborg
2012-06-19 19:00 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120619190008.GA11092@merkur.ravnborg.org \
--to=sam@ravnborg$(echo .)org \
--cc=avi@redhat$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=lethal@linux-sh$(echo .)org \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox