From: Paul Mundt <lethal@linux-sh•org>
To: Fengguang Wu <fengguang.wu@intel•com>
Cc: Randy Dunlap <rdunlap@xenotime•net>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Arnd Bergmann <arnd@arndb•de>
Subject: Re: error: implicit declarations of BUG/BUG_ON/WARN_ON/WARN_ON_ONCE
Date: Mon, 25 Jun 2012 11:53:02 +0900 [thread overview]
Message-ID: <20120625025301.GB9317@linux-sh.org> (raw)
In-Reply-To: <20120622071305.GA15102@localhost>
On Fri, Jun 22, 2012 at 03:13:05PM +0800, Fengguang Wu wrote:
> On Mon, Jun 18, 2012 at 09:54:40AM -0700, Randy Dunlap wrote:
> > On 06/15/2012 09:27 AM, Randy Dunlap wrote:
> >
> > > On 06/14/2012 11:52 PM, Fengguang Wu wrote:
> > >
> > >> On Fri, Jun 15, 2012 at 02:33:03PM +1000, Stephen Rothwell wrote:
> > >>> Hi all,
> > >>>
> > >>> Changes since 20120614:
> > >>>
> > >>> My fixes tree contains:
> > >>> fix bug.h's inclusion of kernel.h
> > >>
> > >> I got these errors with the attached randconfig. Not sure which change
> > >> triggers them.
> > >
> > > Ditto. When CONFIG_BUG is not enabled.
> >
> >
> > This problem is still in linux-next of 20120618...
>
> It's now in Linus' tree..
>
> Paul, any idea to fix this? The attached .config can reproduce the bug.
>
I'm really starting to loathe this header. This should take care of it:
---
diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 506ec19..7d10f96 100644
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -3,10 +3,18 @@
#include <linux/compiler.h>
+#ifdef CONFIG_GENERIC_BUG
+#define BUGFLAG_WARNING (1 << 0)
+#define BUGFLAG_TAINT(taint) (BUGFLAG_WARNING | ((taint) << 8))
+#define BUG_GET_TAINT(bug) ((bug)->flags >> 8)
+#endif
+
+#ifndef __ASSEMBLY__
+#include <linux/kernel.h>
+
#ifdef CONFIG_BUG
#ifdef CONFIG_GENERIC_BUG
-#ifndef __ASSEMBLY__
struct bug_entry {
#ifndef CONFIG_GENERIC_BUG_RELATIVE_POINTERS
unsigned long bug_addr;
@@ -23,17 +31,8 @@ struct bug_entry {
#endif
unsigned short flags;
};
-#endif /* __ASSEMBLY__ */
-
-#define BUGFLAG_WARNING (1 << 0)
-#define BUGFLAG_TAINT(taint) (BUGFLAG_WARNING | ((taint) << 8))
-#define BUG_GET_TAINT(bug) ((bug)->flags >> 8)
-
#endif /* CONFIG_GENERIC_BUG */
-#ifndef __ASSEMBLY__
-#include <linux/kernel.h>
-
/*
* Don't use BUG() or BUG_ON() unless there's really no way out; one
* example might be detecting data structure corruption in the middle
next prev parent reply other threads:[~2012-06-25 2:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 4:33 linux-next: Tree for Jun 15 Stephen Rothwell
2012-06-15 6:52 ` error: implicit declarations of BUG/BUG_ON/WARN_ON/WARN_ON_ONCE Fengguang Wu
2012-06-15 16:27 ` Randy Dunlap
2012-06-18 16:54 ` Randy Dunlap
2012-06-22 7:13 ` Fengguang Wu
2012-06-25 2:53 ` Paul Mundt [this message]
2012-06-25 4:20 ` Fengguang Wu
2012-06-25 4:23 ` Randy Dunlap
2012-06-25 4:38 ` Fengguang Wu
2012-06-25 4:39 ` Randy Dunlap
2012-06-25 4:55 ` Fengguang Wu
2012-06-25 5:05 ` Randy Dunlap
2012-06-25 4:54 ` Paul Mundt
2012-06-15 19:19 ` [PATCH -next] pstore: fix printk format warning in ram.c Randy Dunlap
2012-06-15 19:32 ` Kees Cook
2012-06-22 0:04 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120625025301.GB9317@linux-sh.org \
--to=lethal@linux-sh$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=fengguang.wu@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rdunlap@xenotime$(echo .)net \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox