Subject: Re: [PATCH] mod/file2alias: make modalias generation safe for cross compiling

From: Sam Ravnborg <[email-masked]>
Date: Tue, 26 Jun 2012 07:00:49 +0200

Hi Andreas.

On Mon, Jun 25, 2012 at 02:22:34PM +0200, Andreas Schwab wrote:
> Use the target compiler to compute the offsets of the fields of the
> device_id structures, so that it won't be broken by different alignments
> between the host and target ABIs.
Looks good.

> diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
> index 08dce14..ff22206 100644
> --- a/scripts/Makefile.modpost
> +++ b/scripts/Makefile.modpost
> @@ -80,8 +80,7 @@ modpost = scripts/mod/modpost                    \
>   $(if $(KBUILD_EXTRA_SYMBOLS), $(patsubst %, -e %,$(KBUILD_EXTRA_SYMBOLS))) \
>   $(if $(KBUILD_EXTMOD),-o $(modulesymfile))      \
>   $(if $(CONFIG_DEBUG_SECTION_MISMATCH),,-S)      \
> - $(if $(KBUILD_EXTMOD)$(KBUILD_MODPOST_WARN),-w) \
> - $(if $(cross_build),-c)
> + $(if $(KBUILD_EXTMOD)$(KBUILD_MODPOST_WARN),-w)

With this change we can kill cross_build, and thus we can
drop KBUILD_BUILDHOST too (from top-level Makefile).

	Sam