Subject: Re: [PATCH v2] mfd/regulator: tps65217: Move regulator plat data handling to regulator

From: Samuel Ortiz <[email-masked]>
Date: Wed, 22 Aug 2012 11:02:29 +0200

Hi AnilKumar,

On Mon, Aug 13, 2012 at 08:36:05PM +0530, AnilKumar Ch wrote:
> Regulator platform data handling was mistakenly added to MFD
> driver. So we will see build errors if we compile MFD drivers
> without CONFIG_REGULATOR. This patch moves regulator platform
> data handling from TPS65217 MFD driver to regulator driver.
> 
> This makes MFD driver independent of REGULATOR framework so
> build error is fixed if CONFIG_REGULATOR is not set.
> 
> drivers/built-in.o: In function `tps65217_probe':
> tps65217.c:(.devinit.text+0x13e37): undefined reference
> to `of_regulator_match'
> 
> This patch also fix allocation size of tps65217 platform data.
> Current implementation allocates a struct tps65217_board for each
> regulator specified in the device tree. But the structure itself
> provides array of regulators so one instance of it is sufficient.
> 
> Signed-off-by: AnilKumar Ch <[email-masked]>
> ---
> This patch is tested on BeagleBone with regulator device node
> additions. And this is based on mfd/master.
> 
> Changes from v1:
> 	- Incorporated Matthias Kaehlcke's commets on v1
> 	  * Fixed allocation size of tps65217 platform data
> 
>  drivers/mfd/tps65217.c                 |  130 +++++++++++---------------------
>  drivers/regulator/tps65217-regulator.c |  124 ++++++++++++++++++++++++++----
>  include/linux/mfd/tps65217.h           |   12 ++-
>  3 files changed, 161 insertions(+), 105 deletions(-)
> 
Applied to my for-next and for-linus branches, thanks.
Btw, this is too big of a patch for stable.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/