Subject: Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks

From: Greg KH <[email-masked]>
Date: Wed, 13 Feb 2013 07:54:05 -0800

On Wed, Feb 13, 2013 at 04:58:30PM +0100, Christian Gmeiner wrote:
> During the development of this driver an in-house register
> documentation was used. The last weeks some integration tests
> were done and this problem was found. It turned out that
> the released register documentation is wrong.
> 
> The fix is very simple: shift all masks by one.
> 
> Our customers can control LEDs from userspace via Java,
> C++ or what every. They have running/working applications where
> they want to control led_3 but led_2 get's used.
> I got a bug report in our in-house bug tracker so it would be
> great to fix this upstream.
> 
> Signed-off-by: Christian Gmeiner <[email-masked]>
> ---
>  drivers/leds/leds-ot200.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>