From: Tejun Heo <tj@kernel•org>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: linux-next: manual merge of the akpm tree with the workqueues tree
Date: Wed, 13 Mar 2013 13:51:47 -0700 [thread overview]
Message-ID: <20130313205147.GB22267@htj.dyndns.org> (raw)
In-Reply-To: <20130313124624.1d51184d95d2c69c37daad0d@linux-foundation.org>
Hello, Andrew.
On Wed, Mar 13, 2013 at 12:46:24PM -0700, Andrew Morton wrote:
> Tejun, can you please confirm that this is how worker_pool_assign_id()
> should look in linux-next?
>
> static int worker_pool_assign_id(struct worker_pool *pool)
> {
> int ret;
>
> do {
> idr_preload(GFP_KERNEL);
> spin_lock_irq(&workqueue_lock);
> ret = idr_alloc(&worker_pool_idr, pool, 0, 0, GFP_NOWAIT);
> if (ret >= 0)
> pool->id = ret;
> spin_unlock_irq(&workqueue_lock);
idr_preload_end();
> } while (ret == -EAGAIN);
>
> return ret < 0 ? ret : 0;
> }
Other than that, it looks good to me.
Thanks!
--
tejun
next prev parent reply other threads:[~2013-03-13 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 4:49 linux-next: manual merge of the akpm tree with the workqueues tree Stephen Rothwell
2013-03-13 19:46 ` Andrew Morton
2013-03-13 20:51 ` Tejun Heo [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-15 6:50 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313205147.GB22267@htj.dyndns.org \
--to=tj@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox