From: Tejun Heo <tj@kernel•org>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Fengguang Wu <fengguang.wu@intel•com>
Subject: [PATCH wq/for-3.10] workqueue: define workqueue_freezing static variable iff CONFIG_FREEZER
Date: Tue, 19 Mar 2013 14:01:51 -0700 [thread overview]
Message-ID: <20130319210151.GM3042@htj.dyndns.org> (raw)
In-Reply-To: <20130319145804.7af0b995413adb35d16992ef@canb.auug.org.au>
>From a0265a7f5161b6cb55e82b71edb236bbe0d9b3ae Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@kernel•org>
Date: Tue, 19 Mar 2013 13:55:42 -0700
699ce097efe ("workqueue: implement and use pwq_adjust_max_active()")
replaced the only workqueue_freezing usage outside freezer callbacks
with a POOL_FREEZING test. This makes workqueue_freezing unused when
!CONFIG_FREEZER leading to a compiler warning. Define
workqueue_freezing iff CONFIG_FREEZER.
Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
Reported-by: Fengguang Wu <fengguang.wu@intel•com>
Signed-off-by: Tejun Heo <tj@kernel•org>
---
kernel/workqueue.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index e38d035..775c2f4 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -261,7 +261,9 @@ static DEFINE_SPINLOCK(pwq_lock); /* protects pool_workqueues */
static DEFINE_SPINLOCK(wq_mayday_lock); /* protects wq->maydays list */
static LIST_HEAD(workqueues); /* WQ: list of all workqueues */
+#ifdef CONFIG_FREEZER
static bool workqueue_freezing; /* WQ: have wqs started freezing? */
+#endif
/* the per-cpu worker pools */
static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS],
--
1.8.1.4
prev parent reply other threads:[~2013-03-19 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 3:58 linux-next: build warning after merge of the workqueues tree Stephen Rothwell
2013-03-19 21:01 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319210151.GM3042@htj.dyndns.org \
--to=tj@kernel$(echo .)org \
--cc=fengguang.wu@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox