Subject: Re: [patch] sound/soc/codec : fix build failure in next-201303225

From: Mark Brown <[email-masked]>
Date: Mon, 25 Mar 2013 12:06:01 +0000

On Mon, Mar 25, 2013 at 07:59:43PM +0800, Xiong Zhou wrote:

> -const char *arizona_rate_text[ARIZONA_RATE_ENUM_SIZE] = {
> -	"SYNCCLK rate", "8kHz", "16kHz", "ASYNCCLK rate",
> -};
> +extern const char *arizona_rate_text[ARIZONA_RATE_ENUM_SIZE];
>  EXPORT_SYMBOL_GPL(arizona_rate_text);

No, this isn't a good fix at all - we're moving the array to the header
but still exporting it from this file which is not clever at all.  The
user should be conditional.