From: Asias He <asias@redhat•com>
To: Rusty Russell <rusty@rustcorp•com.au>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
kvm@vger•kernel.org, "Michael S. Tsirkin" <mst@redhat•com>,
netdev@vger•kernel.org, Randy Dunlap <rdunlap@infradead•org>,
linux-kernel@vger•kernel.org,
virtualization@lists•linux-foundation.org,
target-devel@vger•kernel.org, linux-next@vger•kernel.org
Subject: Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec
Date: Thu, 16 May 2013 10:16:36 +0800 [thread overview]
Message-ID: <20130516021636.GA24175@hj.localdomain> (raw)
In-Reply-To: <871u9724vp.fsf@rustcorp.com.au>
On Thu, May 16, 2013 at 09:05:38AM +0930, Rusty Russell wrote:
> "Nicholas A. Bellinger" <nab@linux-iscsi•org> writes:
> > On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote:
> >> Asias He <asias@redhat•com> writes:
> >> > scsi.c includes vhost.c which uses memcpy_fromiovec.
> >> >
> >> > This patch fixes this build failure.
> >> >
> >> > From Randy Dunlap:
> >> > '''
> >> > on x86_64:
> >> >
> >> > ERROR: "memcpy_fromiovec" [drivers/vhost/vhost_scsi.ko] undefined!
> >> >
> >> > It needs to depend on NET since net/core/ provides that function.
> >> > '''
> >>
> >> Proper fix please.
> >>
> >> Though I can't see why you thought this was a good idea. Nonetheless, I
> >> shan't highlight why: I have far too much respect for your intellects
> >> and abilities.
> >>
> >> No, don't thank me!
> >
> > Hi Rusty & Asias,
> >
> > I assume you mean something like the following patch to allow kbuild to
> > work when VHOST_NET + VHOST_SCSI are both enabled and sharing vhost.o,
> > yes..?
>
> No, that's a separate issue.
>
> memcpy_fromiovec() has nothing to do with networking: that was just the
> first user. Note that crypto/algif_skcipher.c also uses it. The
> obvious answer is to move it into lib/.
That's true. I also want this.
> OTOH making vhost_scsi depend on CONFIG_NET is breathtakingly lazy. I
> expect better from experienced kernel hackers :(
But do you think moving the memcpy_fromiovec stuff is a 3.10 material?
> Rusty.
--
Asias
next prev parent reply other threads:[~2013-05-16 2:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 4:17 linux-next: Tree for May 14 Stephen Rothwell
2013-05-14 19:16 ` linux-next: Tree for May 14 (vhost_scsi) Randy Dunlap
2013-05-14 23:55 ` Stephen Rothwell
2013-05-15 0:59 ` [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec Asias He
2013-05-15 3:10 ` Nicholas A. Bellinger
2013-05-15 3:44 ` Asias He
2013-05-15 5:17 ` Rusty Russell
2013-05-15 22:37 ` Nicholas A. Bellinger
2013-05-15 23:35 ` Rusty Russell
2013-05-16 2:16 ` Asias He [this message]
2013-05-16 3:10 ` David Miller
2013-05-16 6:46 ` Michael S. Tsirkin
2013-05-16 9:10 ` David Miller
2013-05-16 1:48 ` Asias He
2013-05-16 6:42 ` Michael S. Tsirkin
2013-05-16 2:08 ` Asias He
2013-05-16 3:34 ` Rusty Russell
2013-05-16 3:55 ` Joe Perches
2013-05-16 23:42 ` Rusty Russell
2013-05-17 4:42 ` Randy Dunlap
2013-05-23 7:30 ` Michael S. Tsirkin
2013-05-16 4:35 ` Asias He
2013-05-16 6:36 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516021636.GA24175@hj.localdomain \
--to=asias@redhat$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=target-devel@vger$(echo .)kernel.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox