From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: "Peng, Tao" <tao.peng@emc•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
"devel@driverdev•osuosl.org" <devel@driverdev•osuosl.org>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
Andreas Dilger <andreas.dilger@intel•com>
Subject: Re: [PATCH] staging/lustre: fix build errors
Date: Tue, 4 Jun 2013 06:59:55 -0700 [thread overview]
Message-ID: <20130604135955.GA25224@kroah.com> (raw)
In-Reply-To: <1882637210201641A747464075FFC6490E57F19F@MX101CL02.corp.emc.com>
On Tue, Jun 04, 2013 at 08:45:41AM +0000, Peng, Tao wrote:
> >From 369398c782c914e5f0548d5bbad22c00c6b58b6a Mon Sep 17 00:00:00 2001
> From: Peng Tao <bergwolf@gmail•com>
> Date: Tue, 4 Jun 2013 15:48:17 +0800
> Subject: [PATCH] staging/lustre: fix build errors
Why send me the whole patch header? If I want to apply this, I need to
hand edit it.
> There are several issues:
> 1. set_cpus_allowed() is not available with CONFIG_CPUMASK_OFFSTACK on
> 2. CONFIG_MODULES may not be defined
> 3. CONFIG_MODULE_UNLOAD may not be defined
You did three different things, please send 3 different patches, I can't
take this as is.
> diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c b/drivers/staging/lustre/lustre/obdclass/lu_object.c
> index 1cbbb6f..da459e1 100644
> --- a/drivers/staging/lustre/lustre/obdclass/lu_object.c
> +++ b/drivers/staging/lustre/lustre/obdclass/lu_object.c
> @@ -1351,7 +1351,9 @@ static void key_fini(struct lu_context *ctx, int index)
>
> LASSERT(key->lct_owner != NULL);
> if ((ctx->lc_tags & LCT_NOREF) == 0) {
> +#ifdef CONFIG_MODULE_UNLOAD
> LINVRNT(module_refcount(key->lct_owner) > 0);
> +#endif
What is that? What is LINVRNT?
> module_put(key->lct_owner);
Are you sure this isn't racy?
> }
> ctx->lc_value[index] = NULL;
> @@ -1933,7 +1935,11 @@ void lu_context_keys_dump(void)
> i, key, key->lct_tags,
> key->lct_init, key->lct_fini, key->lct_exit,
> key->lct_index, atomic_read(&key->lct_used),
> +#ifdef CONFIG_MODULES
> key->lct_owner ? key->lct_owner->name : "",
> +#else
> + "",
> +#endif
That's a mess, why care about a module name at all?
thanks,
greg k-h
next prev parent reply other threads:[~2013-06-04 13:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 8:45 [PATCH] staging/lustre: fix build errors Peng, Tao
2013-06-04 13:59 ` Greg Kroah-Hartman [this message]
2013-06-05 10:33 ` Peng, Tao
2013-06-05 0:42 ` Stephen Rothwell
2013-06-05 10:36 ` Peng, Tao
2013-06-05 11:07 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604135955.GA25224@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=andreas.dilger@intel$(echo .)com \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tao.peng@emc$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox