From: Pavel Machek <pavel@ucw•cz>
To: Wang YanQing <udknight@gmail•com>,
gregkh@linuxfoundation•org, sfr@canb•auug.org.au,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] TTY:vt: convert remain take_over_console's users to do_take_over_console
Date: Tue, 4 Jun 2013 22:13:18 +0200 [thread overview]
Message-ID: <20130604201317.GA16303@amd.pavel.ucw.cz> (raw)
In-Reply-To: <20130521051511.GA11435@udknight>
On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
> Impact:
> 1:convert all remain take_over_console to do_take_over_console
This is step backwards.
> --- a/arch/alpha/kernel/console.c
> +++ b/arch/alpha/kernel/console.c
> @@ -61,7 +61,9 @@ locate_and_init_vga(void *(*sel_func)(void *, void *))
>
> /* Set the VGA hose and init the new console. */
> pci_vga_hose = hose;
> - take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1);
> + console_lock();
> + do_take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1);
> + console_unlock();
> }
Original was better.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-06-04 20:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 5:15 [PATCH] TTY:vt: convert remain take_over_console's users to do_take_over_console Wang YanQing
2013-05-21 13:10 ` Peter Hurley
2013-05-21 14:42 ` Wang YanQing
2013-05-21 15:48 ` Peter Hurley
2013-05-21 16:18 ` Wang YanQing
2013-05-21 16:29 ` Wang YanQing
2013-05-21 17:45 ` Peter Hurley
2013-06-04 20:13 ` Pavel Machek [this message]
2013-06-06 1:23 ` Wang YanQing
2013-06-06 11:47 ` Pavel Machek
2013-06-06 14:22 ` Wang YanQing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604201317.GA16303@amd.pavel.ucw.cz \
--to=pavel@ucw$(echo .)cz \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=udknight@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox