From: Felipe Balbi <balbi@ti•com>
To: Yuan-Hsin Chen <yhchen@faraday-tech•com>
Cc: balbi@ti•com, linux-next@vger•kernel.org,
linux-usb@vger•kernel.org, fengguang.wu@intel•com,
paul.gortmaker@windriver•com
Subject: Re: [PATCH] usb: gadget: fotg210-udc: Use module_platform_driver_probe macro
Date: Thu, 20 Jun 2013 15:16:10 +0300 [thread overview]
Message-ID: <20130620121610.GE9817@arwen.pp.htv.fi> (raw)
In-Reply-To: <1371736393-5518-1-git-send-email-yhchen@faraday-tech.com>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
Hi,
On Thu, Jun 20, 2013 at 01:53:13PM +0000, Yuan-Hsin Chen wrote:
> Because fotg210-udc is configured as a non-hotpluggable device,
> that makes sense to use module_platform_driver_probe() instead of
> module_platform_driver(). This also fixes the section mismatch issue.
>
> Signed-off-by: Yuan-Hsin Chen <yhchen@faraday-tech•com>
I would rather see you remove __init annotation from your probe()
function. The reason being that it will users to bind/unbind the driver
through sysfs, which is pretty good for testing, at least.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-06-20 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 20:06 Section mismatch in drivers/usb/gadget/fotg210-udc.c Paul Gortmaker
[not found] ` <1371736393-5518-1-git-send-email-yhchen@faraday-tech.com>
2013-06-20 12:16 ` Felipe Balbi [this message]
[not found] ` <20130620121610.GE9817-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-06-21 6:36 ` [PATCH] usb: gadget: fotg210-udc: Use module_platform_driver_probe macro Yuan-Hsin Chen
2013-07-03 17:00 ` Section mismatch in drivers/usb/gadget/fotg210-udc.c Paul Gortmaker
[not found] ` <CAP=VYLpsF7bmF2HZ84_WV0YtbGqHoPDMaE=a9p9UhovHeckkRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-03 17:08 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620121610.GE9817@arwen.pp.htv.fi \
--to=balbi@ti$(echo .)com \
--cc=fengguang.wu@intel$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=yhchen@faraday-tech$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox