From: Peter Zijlstra <peterz@infradead•org>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: Gregory CLEMENT <gregory.clement@free-electrons•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
linux-next@vger•kernel.org,
Johannes Berg <johannes.berg@intel•com>,
Steven Rostedt <rostedt@goodmis•org>
Subject: Re: Regression with wait_event_timeout in next-20140226
Date: Wed, 26 Feb 2014 23:35:00 +0100 [thread overview]
Message-ID: <20140226223500.GW9987@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140226142534.3b8c6eb1652d000206948ae0@linux-foundation.org>
On Wed, Feb 26, 2014 at 02:25:34PM -0800, Andrew Morton wrote:
> Is there anything we can do to make all this clearer? Simply using a
> distinctive variable name ("__wait_var__"?) in place of __ret (and
> documenting it) would help a lot.
% s/\<__ret\>/__wait_var__/g should get you mostly there I suppose :-)
Although I'm not entirely sure __wait_var__ is a better name.
> Some __ret's are long and some are int. Maybe that's a glitch,
No that's on purpose.
The longs are needed to hold the timeout values, we truncate to an int
where we only need to return errors.
> maybe
> it's because some __ret's are used for inter-macro communications and
> some are not, which just makes things worse.
The timeout related ones are the worst. The others aren't nearly as bad.
> I started to do a patch, got all confused and gave up. We've made
> quite a tangly mess in there, alas.
Hehe, yes, made a lot of duplicated code go away though. Maybe we
compressed too much, dunno.
next prev parent reply other threads:[~2014-02-26 22:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 16:35 Regression with wait_event_timeout in next-20140226 Gregory CLEMENT
2014-02-26 16:50 ` Peter Zijlstra
2014-02-26 22:25 ` Andrew Morton
2014-02-26 22:35 ` Peter Zijlstra [this message]
2014-04-09 11:16 ` Peter Zijlstra
2014-04-09 19:05 ` Andrew Morton
2014-02-27 3:12 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226223500.GW9987@twins.programming.kicks-ass.net \
--to=peterz@infradead$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=gregory.clement@free-electrons$(echo .)com \
--cc=johannes.berg@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rostedt@goodmis$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox