Subject: Re: [PATCH] topology: Fix compilation warning when not in SMP

From: Greg Kroah-Hartman <[email-masked]>
Date: Fri, 4 Apr 2014 16:49:43 -0700

On Fri, Apr 04, 2014 at 08:43:18AM +0200, Vincent Stehlé wrote:
> The topology_##name() macro does not use its argument when CONFIG_SMP is not
> set, as it ultimately calls the cpu_data() macro.
> 
> So we avoid maintaining a possibly unused `cpu' variable, to avoid the
> following compilation warning:
> 
>   drivers/base/topology.c: In function ‘show_physical_package_id’:
>   drivers/base/topology.c:103:118: warning: unused variable ‘cpu’ [-Wunused-variable]
>    define_id_show_func(physical_package_id);
> 
>   drivers/base/topology.c: In function ‘show_core_id’:
>   drivers/base/topology.c:106:106: warning: unused variable ‘cpu’ [-Wunused-variable]
>    define_id_show_func(core_id);
> 
> This can be seen with e.g. x86 defconfig and CONFIG_SMP not set.
> 
> Signed-off-by: Vincent Stehlé <[email-masked]>
> Cc: Greg Kroah-Hartman <[email-masked]>
> Cc: <[email-masked]> # 3.10.x
> Cc: <[email-masked]> # 3.13.x
> Cc: <[email-masked]> # 3.14.x

Warnings aren't a stable kernel issue, so why would this be relevant
there?

thanks,

greg k-h