Subject: Re: randconfig build error with next-20140513, in drivers/usb/phy/phy-msm-usb.c

From: Felipe Balbi <[email-masked]>
Date: Tue, 13 May 2014 09:56:48 -0500

On Tue, May 13, 2014 at 06:46:05AM -0700, Jim Davis wrote:
> Building with the attached random configuration file,
> 
> drivers/usb/phy/phy-msm-usb.c: In function ‘msm_otg_read_dt’:
> drivers/usb/phy/phy-msm-usb.c:1461:2: error: implicit declaration of
> function ‘devm_reset_control_get’
> [-Werror=implicit-function-declaration]
>   motg->link_rst = devm_reset_control_get(&pdev->dev, "link");
>   ^
> drivers/usb/phy/phy-msm-usb.c:1461:17: warning: assignment makes
> pointer from integer without a cast [enabled by default]
>   motg->link_rst = devm_reset_control_get(&pdev->dev, "link");
>                  ^
> drivers/usb/phy/phy-msm-usb.c:1465:16: warning: assignment makes
> pointer from integer without a cast [enabled by default]
>   motg->phy_rst = devm_reset_control_get(&pdev->dev, "phy");
>                 ^
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/usb/phy/phy-msm-usb.o] Error 1

Here's a patch:

diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index fbbced8..ec531a4 100644
--- a/drivers/usb/phy/Kconfig
+++ b/drivers/usb/phy/Kconfig
@@ -173,6 +173,7 @@ config USB_ISP1301
 config USB_MSM_OTG
 	tristate "Qualcomm on-chip USB OTG controller support"
 	depends on (USB || USB_GADGET) && (ARCH_MSM || ARCH_QCOM || COMPILE_TEST)
+	depends on RESET_CONTROLLER
 	select USB_PHY
 	help
 	  Enable this to support the USB OTG transceiver on Qualcomm chips. It

will send it shortly

-- 
balbi