From: Dmitry Torokhov <dmitry.torokhov@gmail•com>
Cc: sfr@canb•auug.org.au, linux-next@vger•kernel.org,
linux-kernel@vger•kernel.org, Nick Dyer <nick.dyer@itdev•co.uk>
Subject: Re: [PATCH] Input: atmel_mxt_ts - fix build error in mxt_read_t9_resolution
Date: Mon, 26 May 2014 19:09:48 -0700 [thread overview]
Message-ID: <20140527020948.GD12890@core.coreip.homeip.net> (raw)
In-Reply-To: <1400578011-20635-1-git-send-email-nick.dyer@itdev.co.uk>
On Tue, May 20, 2014 at 10:26:51AM +0100, Nick Dyer wrote:
> Stephen Rothwell reports this build error:
>
> drivers/input/touchscreen/atmel_mxt_ts.c: In function 'mxt_read_t9_resolution':
> drivers/input/touchscreen/atmel_mxt_ts.c:1043:2: warning: passing argument 1 of '__swab16s' makes pointer from integer without a cast [enabled by default]
> le16_to_cpus(range.x);
> ^
>
> I believe this is a correct fix.
>
> Signed-off-by: Nick Dyer <nick.dyer@itdev•co.uk>
> ---
> drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
> index d8ea3ed..97495c7 100644
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -1040,8 +1040,8 @@ static int mxt_read_t9_resolution(struct mxt_data *data)
> if (error)
> return error;
>
> - le16_to_cpus(range.x);
> - le16_to_cpus(range.y);
> + le16_to_cpus(&range.x);
> + le16_to_cpus(&range.y);
>
> error = __mxt_read_reg(client,
> object->start_address + MXT_T9_ORIENT,
> --
> 1.8.3.2
>
Thank you, I folded it into the offending patch.
--
Dmitry
next parent reply other threads:[~2014-05-27 2:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1400578011-20635-1-git-send-email-nick.dyer@itdev.co.uk>
2014-05-27 2:09 ` Dmitry Torokhov [this message]
2014-05-20 7:45 linux-next: build warnings after merge of the input tree Stephen Rothwell
2014-05-20 9:54 ` [PATCH] Input: atmel_mxt_ts - fix build error in mxt_read_t9_resolution nick.dyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527020948.GD12890@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=nick.dyer@itdev$(echo .)co.uk \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox