From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Chen Gang <gang.chen.5i5j@gmail•com>
Cc: Guan Xuetao <gxt@mprc•pku.edu.cn>, linux-next@vger•kernel.org
Subject: Re: [Consult] About only one Signed-of-by for the patches
Date: Tue, 27 May 2014 11:34:00 +1000 [thread overview]
Message-ID: <20140527113400.6fa2eeee@canb.auug.org.au> (raw)
In-Reply-To: <5383E91A.4010208@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]
Hi Chen,
On Tue, 27 May 2014 09:23:38 +0800 Chen Gang <gang.chen.5i5j@gmail•com> wrote:
>
> I find some of patches are only Signed-of-by me, are they OK?
Actually, this one is not OK. Anyone who handles a patch needs to add a
Signed-off-by. In the case below, that patch was commited to the tree
by Guan Xuetao <gxt@mprc•pku.edu.cn>, so there needs to be a
Signed-off-by from them as well.
The same is true for all the commits in the unicore32 tree ...
> commit d7de15786d1a10fa18b80fd44026d442e7a84bd2
> Author: Chen Gang <gang.chen.5i5j@gmail•com>
> Date: Tue Apr 15 09:21:30 2014 +0800
>
> arch:unicore32:mm: add devmem_is_allowed() to support STRICT_DEVMEM
>
> unicore32 supports STRICT_DEVMEM, so it needs devmem_is_allowed(), like
> some of other architectures have done (e.g. arm, powerpc, x86 ...).
>
> The related error with allmodconfig:
>
> CC drivers/char/mem.o
> drivers/char/mem.c: In function â<U+0080><U+0098>range_is_allowedâ<U+0080><U+0099>:
> drivers/char/mem.c:69: error: implicit declaration of function â<U+0080><U+0098>devmem_is_allowedâ<U+0080><U+0099>
> make[2]: *** [drivers/char/mem.o] Error 1
> make[1]: *** [drivers/char] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail•com>
> Acked-by: Xuetao Guan <gxt@mprc•pku.edu.cn>
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-27 1:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 1:23 [Consult] About only one Signed-of-by for the patches Chen Gang
2014-05-27 1:34 ` Stephen Rothwell [this message]
2014-05-27 1:50 ` Chen Gang
2014-05-27 5:07 ` 回复： " Xuetao Guan
2014-05-27 22:43 ` Stephen Rothwell
2014-05-28 0:00 ` 回复： " Xuetao Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527113400.6fa2eeee@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=gang.chen.5i5j@gmail$(echo .)com \
--cc=gxt@mprc$(echo .)pku.edu.cn \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox