From: Peter Zijlstra <peterz@infradead•org>
To: "Srivatsa S. Bhat" <srivatsa.bhat@linux•vnet.ibm.com>
Cc: Stephen Warren <swarren@wwwdotorg•org>,
Frederic Weisbecker <fweisbec@gmail•com>,
LKML <linux-kernel@vger•kernel.org>,
Andrew Morton <akpm@linux-foundation•org>,
Eric Dumazet <eric.dumazet@gmail•com>,
Ingo Molnar <mingo@kernel•org>, Kevin Hilman <khilman@linaro•org>,
"Paul E. McKenney" <paulmck@linux•vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix•de>,
Viresh Kumar <viresh.kumar@linaro•org>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>
Subject: Re: [PATCH 2/6] irq_work: Implement remote queueing
Date: Wed, 25 Jun 2014 11:39:44 +0200 [thread overview]
Message-ID: <20140625093944.GV16155@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <20140625093657.GN19860@laptop.programming.kicks-ass.net>
On Wed, Jun 25, 2014 at 11:36:57AM +0200, Peter Zijlstra wrote:
> On Wed, Jun 25, 2014 at 12:07:05PM +0530, Srivatsa S. Bhat wrote:
> > I don't think irqs_disabled() is the problematic condition, since
> > hotplug_cfg() invokes irq_work_run() from CPU_DYING context (which has
> > irqs disabled). I guess you meant to remove the in_irq() check inside
> > irq_work_run() instead?
>
> Yes, clearly I should not get up at 6am.. :-) Let me go do a new one.
---
Subject: irq_work: Remove BUG_ON in irq_work_run()
From: Peter Zijlstra <peterz@infradead•org>
Date: Wed Jun 25 07:13:07 CEST 2014
Because of a collision with 8d056c48e486 ("CPU hotplug, smp: flush any
pending IPI callbacks before CPU offline"), which ends up calling
hotplug_cfd()->flush_smp_call_function_queue()->irq_work_run(), which
is not from IRQ context.
Cc: Frederic Weisbecker <fweisbec@gmail•com>
Reported-by: Stephen Warren <swarren@wwwdotorg•org>
Signed-off-by: Peter Zijlstra <peterz@infradead•org>
Link: http://lkml.kernel.org/n/tip-busatzs2gvz4v62258agipuf@git.kernel.org
---
kernel/irq_work.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
Index: linux-2.6/kernel/irq_work.c
===================================================================
--- linux-2.6.orig/kernel/irq_work.c
+++ linux-2.6/kernel/irq_work.c
@@ -160,21 +160,11 @@ static void irq_work_run_list(struct lli
}
}
-static void __irq_work_run(void)
+static void irq_work_run(void)
{
irq_work_run_list(&__get_cpu_var(raised_list));
irq_work_run_list(&__get_cpu_var(lazy_list));
}
-
-/*
- * Run the irq_work entries on this cpu. Requires to be ran from hardirq
- * context with local IRQs disabled.
- */
-void irq_work_run(void)
-{
- BUG_ON(!in_irq());
- __irq_work_run();
-}
EXPORT_SYMBOL_GPL(irq_work_run);
/*
next prev parent reply other threads:[~2014-06-25 9:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1402413309-3415-1-git-send-email-fweisbec@gmail.com>
[not found] ` <1402413309-3415-3-git-send-email-fweisbec@gmail.com>
2014-06-24 20:33 ` [PATCH 2/6] irq_work: Implement remote queueing Stephen Warren
2014-06-24 20:35 ` Stephen Warren
2014-06-25 5:12 ` Peter Zijlstra
2014-06-25 5:17 ` Peter Zijlstra
2014-06-25 6:37 ` Srivatsa S. Bhat
2014-06-25 9:36 ` Peter Zijlstra
2014-06-25 9:39 ` Peter Zijlstra [this message]
2014-06-25 9:50 ` Srivatsa S. Bhat
2014-06-25 9:54 ` Srivatsa S. Bhat
2014-06-25 10:19 ` Peter Zijlstra
2014-06-25 10:57 ` Srivatsa S. Bhat
2014-06-25 16:23 ` Stephen Warren
2014-06-25 16:38 ` Peter Zijlstra
2014-06-25 16:57 ` Srivatsa S. Bhat
2014-06-28 18:19 ` Borislav Petkov
2014-07-03 14:52 ` Frederic Weisbecker
2014-07-04 5:10 ` Sachin Kamat
2014-07-01 19:13 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140625093944.GV16155@laptop.programming.kicks-ass.net \
--to=peterz@infradead$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=fweisbec@gmail$(echo .)com \
--cc=khilman@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mingo@kernel$(echo .)org \
--cc=paulmck@linux$(echo .)vnet.ibm.com \
--cc=srivatsa.bhat@linux$(echo .)vnet.ibm.com \
--cc=swarren@wwwdotorg$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=viresh.kumar@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox