From: Grant Likely <grant.likely@secretlab•ca>
To: Rob Herring <robherring2@gmail•com>,
Vineet Gupta <Vineet.Gupta1@synopsys•com>
Cc: linux-next <linux-next@vger•kernel.org>,
Anton Kolesov <Anton.Kolesov@synopsys•com>,
lkml <linux-kernel@vger•kernel.org>,
greg Kroah-Hartman <gregkh@linuxfoundation•org>,
"linux-serial@vger•kernel.org" <linux-serial@vger•kernel.org>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>
Subject: Re: ARC fails to boot on linux-next of 20140711
Date: Fri, 25 Jul 2014 23:33:44 -0600 [thread overview]
Message-ID: <20140726053344.95800C40C93@trevor.secretlab.ca> (raw)
In-Reply-To: <CAL_JsqJ2q0RSvXQW03RqwwBi_TKQ7Zt6DsUbsUruzh5oqYi5Cg@mail.gmail.com>
On Fri, 25 Jul 2014 09:15:22 -0500, Rob Herring <robherring2@gmail•com> wrote:
> On Fri, Jul 25, 2014 at 6:02 AM, Vineet Gupta
> <Vineet.Gupta1@synopsys•com> wrote:
> > Hi Grant,
> >
> > linux-next has a series for arc_uart (via tty tree) which converts it to generic
> > earlycon and specifies console via /chosen/stdout-path vs. an explicit param in
> > /chose/bootargs
> >
> > 2014-06-24 9da433c0a0b5 ARC: [arcfpga] stdout-path now suffices for earlycon/console
> >
> > This relied on prev commit of yours (from linux next of 20140711), which seem to
> > have disappeared now.
> >
> > 2014-03-27 a9296cf2d0b6 of: Create of_console_check() for selecting a console
> > specified in /chosen
> > 2014-03-27 cfa9cacc5dd3 of: Enable console on serial ports specified by
> > /chosen/stdout-path
> >
> > Is there a specific reason for dropping these patches (or perhaps a merge to be
> > merged). I cherry-picked both but still doesn't work.
> >
> > Can you please advise next step forward, before I go off debugging with those
> > patches in.
>
> There's an issue that if you have stdout-path and "earlycon" on the
> command line, the kernel will switch to tty0 and disable the earlycon.
>
> This is the "fix", but I don't like adding the DT dependency into generic code:
Yes, I'm not fond of it either. I've not been able to test it though and
work out a proper bug fix. As far as I can understand, the earlycon code
only works on aarch64, correct? I haven't been able to get an aarch64
boot working in QEMU yet.
g.
>
> @@ -2382,7 +2386,7 @@ void register_console(struct console *newcon)
> if (newcon->setup == NULL ||
> newcon->setup(newcon, NULL) == 0) {
> newcon->flags |= CON_ENABLED;
> - if (newcon->device) {
> + if (newcon->device && !of_stdout) {
> newcon->flags |= CON_CONSDEV;
> preferred_console = 0;
> }
>
> Rob
next prev parent reply other threads:[~2014-07-26 5:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 11:02 ARC fails to boot on linux-next of 20140711 Vineet Gupta
2014-07-25 11:26 ` Vineet Gupta
2014-07-25 14:15 ` Rob Herring
2014-07-26 5:33 ` Grant Likely [this message]
2014-07-26 6:53 ` Vineet Gupta
2014-07-26 15:17 ` Guenter Roeck
2014-07-26 6:52 ` Vineet Gupta
2014-07-26 16:50 ` Grant Likely
2014-07-26 20:10 ` Rob Herring
2014-07-31 3:25 ` Grant Likely
[not found] ` <20140731032527.D2C5AC40A02-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-07-31 15:12 ` Rob Herring
2014-07-28 4:38 ` Vineet Gupta
2014-07-30 23:53 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140726053344.95800C40C93@trevor.secretlab.ca \
--to=grant.likely@secretlab$(echo .)ca \
--cc=Anton.Kolesov@synopsys$(echo .)com \
--cc=Vineet.Gupta1@synopsys$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=robherring2@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox