From: Michal Hocko <mhocko@suse•cz>
To: akpm@linux-foundation•org
Cc: mm-commits@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-mm@kvack•org, linux-fsdevel@vger•kernel.org,
linux-next@vger•kernel.org, sfr@canb•auug.org.au,
Atsushi Kumagai <kumagai-atsushi@mxc•nes.nec.co.jp>,
Baoquan He <bhe@redhat•com>, Vivek Goyal <vgoyal@redhat•com>
Subject: [PATCH] kexec-export-free_huge_page-to-vmcoreinfo-fix (was: Re: mmotm 2014-07-30-15-57 uploaded)
Date: Thu, 31 Jul 2014 11:24:52 +0200 [thread overview]
Message-ID: <20140731092452.GB13561@dhcp22.suse.cz> (raw)
In-Reply-To: <53d978aa.dtIIGjOqrXXmAm4e%akpm@linux-foundation.org>
On Wed 30-07-14 15:58:50, Andrew Morton wrote:
> * kexec-export-free_huge_page-to-vmcoreinfo.patch
This one seems to be missing ifdef for CONFIG_HUGETLBFS
---
From bcccb6696b89c700712421858b05dd89ea0d1ec5 Mon Sep 17 00:00:00 2001
From: Michal Hocko <mhocko@suse•cz>
Date: Thu, 31 Jul 2014 11:18:57 +0200
Subject: [PATCH] kexec-export-free_huge_page-to-vmcoreinfo-fix
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
free_huge_page is not defined for !CONFIG_HUGETLBFS. Fix the following
compilation error:
kernel/kexec.c: In function ‘crash_save_vmcoreinfo_init’:
kernel/kexec.c:1628:20: error: ‘free_huge_page’ undeclared (first use in this function)
VMCOREINFO_SYMBOL(free_huge_page);
Signed-off-by: Michal Hocko <mhocko@suse•cz>
---
kernel/kexec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/kexec.c b/kernel/kexec.c
index a3ccf9d7174b..507614acf938 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1625,7 +1625,9 @@ static int __init crash_save_vmcoreinfo_init(void)
#endif
VMCOREINFO_NUMBER(PG_head_mask);
VMCOREINFO_NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE);
+#ifdef CONFIG_HUGETLBFS
VMCOREINFO_SYMBOL(free_huge_page);
+#endif
arch_crash_save_vmcoreinfo();
update_vmcoreinfo_note();
--
2.0.1
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2014-07-31 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 22:58 mmotm 2014-07-30-15-57 uploaded akpm
2014-07-31 9:24 ` Michal Hocko [this message]
2014-07-31 10:01 ` [PATCH] kexec-export-free_huge_page-to-vmcoreinfo-fix (was: Re: mmotm 2014-07-30-15-57 uploaded) Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731092452.GB13561@dhcp22.suse.cz \
--to=mhocko@suse$(echo .)cz \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bhe@redhat$(echo .)com \
--cc=kumagai-atsushi@mxc$(echo .)nes.nec.co.jp \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mm-commits@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=vgoyal@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox