Subject: Re: [PATCH] DRBG: fix maximum value checks on 32 bit systems

From: Herbert Xu <[email-masked]>
Date: Tue, 26 Aug 2014 16:08:58 +0800

On Tue, Aug 26, 2014 at 10:06:52AM +0200, Stephan Mueller wrote:
> The maximum values for additional input string or generated blocks is
> larger than 1<<32. To ensure a sensible value on 32 bit systems, return
> SIZE_MAX on 32 bit systems. This value is lower than the maximum allowed
> values defined in SP800-90A. The standard allow lower maximum values,
> but not larger values.
> 
> Reported-by: Stephen Rothwell <[email-masked]>
> Reported-by: kbuild test robot <[email-masked]>
> Signed-off-by: Stephan Mueller <[email-masked]>

Unfortunately there's a place in drbg where you add one to
drbg_max_addtl which will cause it to overflow back to zero.

Cheers,
-- 
Email: Herbert Xu <[email-masked]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt