Subject: Re: [PATCH linux-next] clk-gpio-gate: include gpio/consumer to fix build

From: Mike Turquette <[email-masked]>
Date: Tue, 30 Sep 2014 14:27:30 -0700

Quoting Vincent Stehlé (2014-09-30 12:36:43)
> This fixes the following build error:
> 
>   drivers/clk/clk-gpio-gate.c: In function ‘clk_gpio_gate_enable’:
>   drivers/clk/clk-gpio-gate.c:36:2: error: implicit declaration of function ‘gpiod_set_value’ [-Werror=implicit-function-declaration]
>   drivers/clk/clk-gpio-gate.c: In function ‘clk_gpio_gate_is_enabled’:
>   drivers/clk/clk-gpio-gate.c:52:2: error: implicit declaration of function ‘gpiod_get_value’ [-Werror=implicit-function-declaration]
>   drivers/clk/clk-gpio-gate.c: In function ‘clk_register_gpio_gate’:
>   drivers/clk/clk-gpio-gate.c:79:2: error: implicit declaration of function ‘gpiod_is_active_low’ [-Werror=implicit-function-declaration]
>   drivers/clk/clk-gpio-gate.c:85:3: error: implicit declaration of function ‘desc_to_gpio’ [-Werror=implicit-function-declaration]
>   drivers/clk/clk-gpio-gate.c:125:2: error: implicit declaration of function ‘gpiod_put’ [-Werror=implicit-function-declaration]
>   drivers/clk/clk-gpio-gate.c: In function ‘of_clk_gpio_gate_delayed_register_get’:
>   drivers/clk/clk-gpio-gate.c:169:2: error: implicit declaration of function ‘gpio_to_desc’ [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Vincent Stehlé <[email-masked]>
> Cc: Jyri Sarha <[email-masked]>
> Cc: Mike Turquette <[email-masked]>
> ---
> 
> Hi,
> 
> This can be seen with e.g. linux next-20140930 and arm alldefconfig.

Fixed with:

https://git.linaro.org/people/mike.turquette/linux.git/commit/44b4aa97bea84fa8ac179155f147e3483cc7a6e0

Regards,
Mike

> 
> Best regards,
> 
> V.
> 
>  drivers/clk/clk-gpio-gate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/clk-gpio-gate.c b/drivers/clk/clk-gpio-gate.c
> index 9dde885..08e4322 100644
> --- a/drivers/clk/clk-gpio-gate.c
> +++ b/drivers/clk/clk-gpio-gate.c
> @@ -13,6 +13,7 @@
>  #include <linux/module.h>
>  #include <linux/slab.h>
>  #include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/of_gpio.h>
>  #include <linux/err.h>
>  #include <linux/device.h>
> -- 
> 2.1.0
>