From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Tomi Valkeinen <tomi.valkeinen@ti•com>
Cc: Hans de Goede <hdegoede@redhat•com>,
David Herrmann <dh.herrmann@gmail•com>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
linux-kernel <linux-kernel@vger•kernel.org>,
Luc Verhaegen <libv@skynet•be>,
Geert Uytterhoeven <geert@linux-m68k•org>,
Maxime Ripard <maxime.ripard@free-electrons•com>,
Grant Likely <grant.likely@linaro•org>
Subject: Re: linux-next: build failure after merge of the omap_dss2 tree
Date: Wed, 26 Nov 2014 09:07:37 +1100 [thread overview]
Message-ID: <20141126090737.2860d33c@canb.auug.org.au> (raw)
In-Reply-To: <5474720F.5030106@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]
Hi Tomi,
On Tue, 25 Nov 2014 14:11:59 +0200 Tomi Valkeinen <tomi.valkeinen@ti•com> wrote:
>
> On 25/11/14 13:20, Hans de Goede wrote:
> >
> > On 11/25/2014 12:00 PM, Tomi Valkeinen wrote:
> >> On 18/11/14 17:07, David Herrmann wrote:
> >>>
> >>> On Tue, Nov 18, 2014 at 3:53 PM, Tomi Valkeinen
> >>> <tomi.valkeinen@ti•com> wrote:
> >>>>
> >>>> Thanks Stephen!
> >>>>
> >>>> Hans, have you had a look at this? kbuild test bot also reported this.
> >>>
> >>> The fix from Stephen should not go to main-line. It breaks simplefb on
> >>> x86 without OF. Imo, linux/clk.h should provide a fallback if OF is
> >>> not defined (like it already does for of_clk_get() and friends).
> >>>
> >>> Hans, any comments?
> >>
> >> Hans, ping.
> >
> > Sorry I somehow missed this thread so far, I did see the kbuild mail, but
> > it looked like a false positive to me, for the compile error case I
> > already fixed
> > in the last revision of the patch, adding #ifdef CONFIG_OF around the
> > offending code.
> >
> > But on closer inspection I see that the entirety of linux/clk-provider.h
> > is wrapped
> > in one huge #ifdef CONFIG_COMMON_CLK and then later on also has:
> >
> > #ifdef CONFIG_OF
> > ...
> > int of_clk_get_parent_count(struct device_node *np);
> > ...
> > #endif
> >
> > So we need both CONFIG_OF and CONFIG_COMMON_CLK, the attached patch
> > should fix this.
>
> Thanks, applied.
But not pushed out, yet? Just checking that you haven't pushed on
purpose.
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-25 22:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 8:09 linux-next: build failure after merge of the omap_dss2 tree Stephen Rothwell
2014-11-18 14:53 ` Tomi Valkeinen
2014-11-18 15:07 ` David Herrmann
2014-11-25 11:00 ` Tomi Valkeinen
2014-11-25 11:20 ` Hans de Goede
2014-11-25 12:11 ` Tomi Valkeinen
2014-11-25 22:07 ` Stephen Rothwell [this message]
2014-11-26 8:16 ` Tomi Valkeinen
-- strict thread matches above, loose matches on Subject: below --
2014-03-05 3:32 Stephen Rothwell
2014-03-05 7:01 ` Tomi Valkeinen
2014-03-04 3:35 Stephen Rothwell
2014-03-04 6:58 ` Tomi Valkeinen
2013-04-26 5:10 Stephen Rothwell
2013-04-26 5:31 ` Tomi Valkeinen
2013-04-26 5:56 ` Stephen Rothwell
2013-04-26 6:57 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126090737.2860d33c@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=dh.herrmann@gmail$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=grant.likely@linaro$(echo .)org \
--cc=hdegoede@redhat$(echo .)com \
--cc=libv@skynet$(echo .)be \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=maxime.ripard@free-electrons$(echo .)com \
--cc=tomi.valkeinen@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox