From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Daniel Vetter <daniel.vetter@ffwll•ch>,
intel-gfx@lists•freedesktop.org, dri-devel@lists•freedesktop.org,
Dave Airlie <airlied@linux•ie>
Cc: "Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard•com>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
"Lars-Peter Clausen" <lars@metafoo•de>,
"Stefan Brüns" <stefan.bruens@rwth-aachen•de>
Subject: linux-next: manual merge of the drm-misc tree with the drm tree
Date: Wed, 3 Dec 2014 13:43:55 +1100 [thread overview]
Message-ID: <20141203134355.6fd6e3b7@canb.auug.org.au> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 2022 bytes --]
Hi all,
Today's linux-next merge of the drm-misc tree got a conflict in
drivers/gpu/drm/drm_edid.c between commit 18df89fef2d5 ("drm: Decouple
EDID parsing from I2C adapter") from the drm tree and commit
d6885d659037 ("drm/edid: move drm_edid_is_zero to top, make edid
argument const") from the drm-misc tree.
I fixed it up (see below) and can carry the fix as necessary (no action
is required).
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
diff --cc drivers/gpu/drm/drm_edid.c
index a7b5a71856a7,2c1d2e49fb6f..000000000000
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@@ -1176,34 -1196,8 +1196,26 @@@ drm_do_probe_ddc_edid(void *data, u8 *b
return ret == xfers ? 0 : -1;
}
- static bool drm_edid_is_zero(u8 *in_edid, int length)
- {
- if (memchr_inv(in_edid, 0, length))
- return false;
-
- return true;
- }
-
-static u8 *
-drm_do_get_edid(struct drm_connector *connector, struct i2c_adapter *adapter)
+/**
+ * drm_do_get_edid - get EDID data using a custom EDID block read function
+ * @connector: connector we're probing
+ * @get_edid_block: EDID block read function
+ * @data: private data passed to the block read function
+ *
+ * When the I2C adapter connected to the DDC bus is hidden behind a device that
+ * exposes a different interface to read EDID blocks this function can be used
+ * to get EDID data using a custom block read function.
+ *
+ * As in the general case the DDC bus is accessible by the kernel at the I2C
+ * level, drivers must make all reasonable efforts to expose it as an I2C
+ * adapter and use drm_get_edid() instead of abusing this function.
+ *
+ * Return: Pointer to valid EDID or NULL if we couldn't find any.
+ */
+struct edid *drm_do_get_edid(struct drm_connector *connector,
+ int (*get_edid_block)(void *data, u8 *buf, unsigned int block,
+ size_t len),
+ void *data)
{
int i, j = 0, valid_extensions = 0;
u8 *block, *new;
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists•freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2014-12-03 2:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 2:43 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-10 1:49 linux-next: manual merge of the drm-misc tree with the drm tree Stephen Rothwell
2016-09-28 2:11 Stephen Rothwell
2017-04-03 3:18 Stephen Rothwell
2017-11-01 3:36 Stephen Rothwell
2018-03-19 1:29 Stephen Rothwell
2018-03-19 14:14 ` Ville Syrjälä
2018-09-12 0:39 Stephen Rothwell
2018-09-18 1:31 Stephen Rothwell
2018-11-23 0:13 Stephen Rothwell
2019-02-08 1:27 Stephen Rothwell
2019-02-08 8:53 ` Daniel Vetter
2019-02-08 9:25 ` Stephen Rothwell
2019-02-08 9:34 ` Daniel Vetter
2019-04-09 1:34 Stephen Rothwell
2019-04-09 7:23 ` Gerd Hoffmann
2019-06-11 3:38 Stephen Rothwell
2019-06-11 3:52 Stephen Rothwell
2019-08-19 3:18 Stephen Rothwell
2019-10-08 23:33 Stephen Rothwell
2019-10-08 23:38 Stephen Rothwell
2019-10-08 23:46 Stephen Rothwell
2019-10-09 0:10 Stephen Rothwell
2019-10-09 0:12 Stephen Rothwell
2022-11-09 23:54 Stephen Rothwell
2025-07-01 3:07 Stephen Rothwell
2025-07-01 3:21 ` Stephen Rothwell
2026-03-30 16:02 Mark Brown
2026-03-30 16:02 Mark Brown
2026-04-03 13:34 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203134355.6fd6e3b7@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=airlied@linux$(echo .)ie \
--cc=daniel.vetter@ffwll$(echo .)ch \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=lars@metafoo$(echo .)de \
--cc=laurent.pinchart+renesas@ideasonboard$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=stefan.bruens@rwth-aachen$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox