From: David Miller <davem@davemloft•net>
To: jim.epost@gmail•com
Cc: sfr@canb•auug.org.au, linux-next@vger•kernel.org,
linux-kernel@vger•kernel.org, f.fainelli@gmail•com,
netdev@vger•kernel.org
Subject: Re: randconfig build error with next-20141210, in drivers/net/ethernet/broadcom/genet
Date: Thu, 11 Dec 2014 14:22:20 -0500 (EST) [thread overview]
Message-ID: <20141211.142220.610076934853342634.davem@davemloft.net> (raw)
In-Reply-To: <CA+r1ZhjxtK8BtF16Mr9jXjqvFVV7KAAFjWqfVFUibNreZwZxTw@mail.gmail.com>
From: Jim Davis <jim.epost@gmail•com>
Date: Wed, 10 Dec 2014 09:10:45 -0700
> Building with the attached random configuration file,
>
> ERROR: "fixed_phy_register"
> [drivers/net/ethernet/broadcom/genet/genet.ko] undefined!
Florian, I don't understand why FIXED_PHY is only selected in Kconfig
if the driver is statically built into the kernel.
That makes no sense at all, you should need that module regardless of
how the driver itself is enabled.
Can't we just remove the "XXX=y" in all of those silly:
select FIXED_PHY if XXX=y
expressions?
There are three such cases right now:
drivers/net/dsa/Kconfig: select FIXED_PHY if NET_DSA_BCM_SF2=y
drivers/net/ethernet/broadcom/Kconfig: select FIXED_PHY if BCMGENET=y
drivers/net/ethernet/broadcom/Kconfig: select FIXED_PHY if SYSTEMPORT=y
next prev parent reply other threads:[~2014-12-11 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 16:10 randconfig build error with next-20141210, in drivers/net/ethernet/broadcom/genet Jim Davis
2014-12-11 19:22 ` David Miller [this message]
2014-12-12 5:09 ` Florian Fainelli
2014-12-12 16:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211.142220.610076934853342634.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jim.epost@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox