From: Andrew Morton <akpm@linux-foundation•org>
To: Jiri Kosina <jkosina@suse•cz>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Josh Poimboeuf <jpoimboe@redhat•com>,
Christoph Hellwig <hch@infradead•org>,
linux-kernel@vger•kernel.org, live-patching@vger•kernel.org,
linux-next@vger•kernel.org, Steven Rostedt <rostedt@goodmis•org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi•com>
Subject: Re: livepatching tree for linux-next
Date: Wed, 7 Jan 2015 15:30:06 -0800 [thread overview]
Message-ID: <20150107153006.60ed354e3458f402e6819b9e@linux-foundation.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1501072346400.15299@pobox.suse.cz>
On Thu, 8 Jan 2015 00:01:02 +0100 (CET) Jiri Kosina <jkosina@suse•cz> wrote:
> On Wed, 7 Jan 2015, Andrew Morton wrote:
>
> > > OK, I have added this from today
> >
> > My x86_64 allmodconfig broke.
> >
> > In file included from include/linux/livepatch.h:29,
> > from kernel/livepatch/core.c:30:
> > ./arch/x86/include/asm/livepatch.h:29:2: error: #error Your compiler must support -mfentry for live patching to work
>
> [ adding Steven and Masami to CC, as this in some sense is related in
> both to ftrace regs caller, and to IPMODIFY users in general ]
>
> Well, if your gcc is too old (which is a fact detemined during build time,
> so there is no way to express this in Kconfig language in form of
> dependencies), we have to introduce build-time failure, as there is no way
> for this to work on compilers that don't support fentry on x86_64.
>
> The only remaining option is to let the code build, pretend that
> everything is working, but do something like
>
> #ifndef CC_USING_FENTRY
> printk("The compiler you used to compile your kernel was ancient "
> "there is no way for you to make use of this feature\n");
> return -EINVAL;
> #endif
>
> or so ... which I personally detest even more.
um, what's so special about this patchset that it gets to be the first
code in the history of the kernel which breaks allmodconfig?
Please find a way to fix it. Copying CONFIG_CC_STACKPROTECTOR is one way.
next prev parent reply other threads:[~2015-01-07 23:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 19:52 livepatching tree for linux-next Jiri Kosina
2014-12-23 9:46 ` Christoph Hellwig
2014-12-23 15:10 ` Josh Poimboeuf
2014-12-26 4:56 ` Stephen Rothwell
2015-01-07 22:43 ` Andrew Morton
2015-01-07 23:01 ` Jiri Kosina
2015-01-07 23:30 ` Andrew Morton [this message]
2015-01-07 23:49 ` Jiri Kosina
2015-01-07 23:57 ` Andrew Morton
2015-01-08 0:11 ` Jiri Kosina
2015-01-08 0:33 ` Andrew Morton
2015-01-08 2:22 ` Jingoo Han
2015-01-12 12:45 ` Masami Hiramatsu
2015-01-13 22:47 ` [PATCH] ftrace: don't allow IPMODIFY without proper compiler support (was Re: Re: livepatching tree for linux-next) Jiri Kosina
2015-01-14 2:12 ` Steven Rostedt
2015-01-14 8:47 ` [PATCH 1/2 v2] ftrace: don't allow IPMODIFY without proper compiler support Jiri Kosina
2015-01-14 8:48 ` [PATCH 2/2] kprobes: compile out IPMODIFY support if ftrace doesn't support it Jiri Kosina
2015-01-15 3:04 ` Masami Hiramatsu
2015-01-15 3:34 ` [PATCH 1/2 v2] ftrace: don't allow IPMODIFY without proper compiler support Masami Hiramatsu
2015-01-15 9:34 ` Jiri Kosina
2015-01-15 9:50 ` [PATCH 1/2 v3] " Jiri Kosina
2015-01-15 9:50 ` [PATCH 2/2 v3] kprobes: compile out IPMODIFY support if ftrace doesn't support it Jiri Kosina
2015-01-16 16:35 ` [PATCH 1/2 v3] ftrace: don't allow IPMODIFY without proper compiler support Steven Rostedt
2015-01-16 16:41 ` Jiri Kosina
2015-01-16 16:53 ` Steven Rostedt
2015-01-14 2:34 ` [PATCH] ftrace: don't allow IPMODIFY without proper compiler support (was Re: Re: livepatching tree for linux-next) Masami Hiramatsu
2015-01-14 8:34 ` Jiri Kosina
2015-01-09 10:03 ` livepatching tree for linux-next Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107153006.60ed354e3458f402e6819b9e@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=hch@infradead$(echo .)org \
--cc=jkosina@suse$(echo .)cz \
--cc=jpoimboe@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=live-patching@vger$(echo .)kernel.org \
--cc=masami.hiramatsu.pt@hitachi$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox