From: "Peter Hüwe" <PeterHuewe@gmx•de>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next <linux-next@vger•kernel.org>,
tpmdd-devel@lists•sourceforge.net,
Jarkko Sakkinen <jarkko.sakkinen@linux•intel.com>,
Jim Davis <jim.epost@gmail•com>
Subject: Re: [PATCH] tpm/tpm_tis: Add missing ifdef CONFIG_ACPI for pnp_acpi_device
Date: Wed, 21 Jan 2015 23:40:04 +0100 [thread overview]
Message-ID: <201501212340.05536.PeterHuewe@gmx.de> (raw)
In-Reply-To: <20150122083432.2adaaee2@canb.auug.org.au>
Am Mittwoch, 21. Januar 2015, 22:34:32 schrieb Stephen Rothwell:
> Hi Peter,
>
> On Thu, 22 Jan 2015 08:23:50 +1100 Stephen Rothwell <sfr@canb•auug.org.au>
wrote:
> > To save on the ifdef, why not
> >
> > struct acpi_device *acpi;
> >
> > .
> > .
> >
> > acpi = pnp_acpi_device(dev);
> > if (acpi)
> >
> > acpi_dev_handle = acpi->handle;
>
> I guess struct acpi_device may not be visible when CONFIG_ACPI is not
> set? That would be a pain :-(
Yeah seems like it :(
I also thought about this way but then decided against it for the obvious
reason.
Stephen, do you pull this patch in directly or shall it go via my tpmdd-tree -
> james -> -next ?
> As an aside, the dummy pnp_acpi_device() should be returning NULL not
> 0, and could be a static inline function (as could several other things
> in that header.
Yeah, probably.
(although this function is only in exactly two places within the kernel... so
not much is gained here:)
Maybe I'll post a patch or maybe we can get rid of this whole thing
altogether.
Let me think about it.
Peter
next prev parent reply other threads:[~2015-01-21 22:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 20:40 [PATCH] tpm/tpm_tis: Add missing ifdef CONFIG_ACPI for pnp_acpi_device Peter Huewe
2015-01-21 21:23 ` Stephen Rothwell
2015-01-21 21:34 ` Stephen Rothwell
2015-01-21 22:40 ` Peter Hüwe [this message]
2015-01-21 23:05 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2015-01-21 23:42 Peter Huewe
2015-01-22 2:22 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201501212340.05536.PeterHuewe@gmx.de \
--to=peterhuewe@gmx$(echo .)de \
--cc=jarkko.sakkinen@linux$(echo .)intel.com \
--cc=jim.epost@gmail$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tpmdd-devel@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox