public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Roland Dreier <roland@kernel•org>, linux-rdma@vger•kernel.org
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	Or Gerlitz <ogerlitz@mellanox•com>,
	Moni Shoua <monis@mellanox•com>,
	"David S. Miller" <davem@davemloft•net>
Subject: linux-next: manual merge of the infiniband tree with Linus' tree
Date: Wed, 18 Feb 2015 11:29:08 +1100	[thread overview]
Message-ID: <20150218112908.5e2eaee5@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2484 bytes --]

Hi all,

Today's linux-next merge of the infiniband tree got a conflict in
drivers/infiniband/hw/mlx4/main.c between commit 146d6e19832a
("IB/mlx4: Create mirror flows in port aggregation mode") from Linus'
tree and commit e9a7faf11af9 ("IB/mlx4: Fix wrong usage of IPv4
protocol for multicast attach/detach") from the infiniband tree.

I fixed it up (see below) and can carry the fix as necessary (no action
is required).

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au

diff --cc drivers/infiniband/hw/mlx4/main.c
index eb8e215f1613,0b280b1c98df..000000000000
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@@ -1266,12 -1219,10 +1266,11 @@@ static int mlx4_ib_mcg_attach(struct ib
  {
  	int err;
  	struct mlx4_ib_dev *mdev = to_mdev(ibqp->device);
 +	struct mlx4_dev	*dev = mdev->dev;
  	struct mlx4_ib_qp *mqp = to_mqp(ibqp);
 -	u64 reg_id;
  	struct mlx4_ib_steering *ib_steering = NULL;
- 	enum mlx4_protocol prot = (gid->raw[1] == 0x0e) ?
- 		MLX4_PROT_IB_IPV4 : MLX4_PROT_IB_IPV6;
+ 	enum mlx4_protocol prot = MLX4_PROT_IB_IPV6;
 +	struct mlx4_flow_reg_id	reg_id;
  
  	if (mdev->dev->caps.steering_mode ==
  	    MLX4_STEERING_MODE_DEVICE_MANAGED) {
@@@ -1283,21 -1234,12 +1282,23 @@@
  	err = mlx4_multicast_attach(mdev->dev, &mqp->mqp, gid->raw, mqp->port,
  				    !!(mqp->flags &
  				       MLX4_IB_QP_BLOCK_MULTICAST_LOOPBACK),
 -				    prot, &reg_id);
 +				    prot, &reg_id.id);
- 	if (err)
+ 	if (err) {
+ 		pr_err("multicast attach op failed, err %d\n", err);
  		goto err_malloc;
+ 	}
  
 +	reg_id.mirror = 0;
 +	if (mlx4_is_bonded(dev)) {
 +		err = mlx4_multicast_attach(mdev->dev, &mqp->mqp, gid->raw,
 +					    (mqp->port == 1) ? 2 : 1,
 +					    !!(mqp->flags &
 +					    MLX4_IB_QP_BLOCK_MULTICAST_LOOPBACK),
 +					    prot, &reg_id.mirror);
 +		if (err)
 +			goto err_add;
 +	}
 +
  	err = add_gid_entry(ibqp, gid);
  	if (err)
  		goto err_add;
@@@ -1347,10 -1285,8 +1348,9 @@@ static int mlx4_ib_mcg_detach(struct ib
  	struct mlx4_ib_qp *mqp = to_mqp(ibqp);
  	struct net_device *ndev;
  	struct mlx4_ib_gid_entry *ge;
 -	u64 reg_id = 0;
 +	struct mlx4_flow_reg_id reg_id = {0, 0};
 +
- 	enum mlx4_protocol prot = (gid->raw[1] == 0x0e) ?
- 		MLX4_PROT_IB_IPV4 : MLX4_PROT_IB_IPV6;
+ 	enum mlx4_protocol prot =  MLX4_PROT_IB_IPV6;
  
  	if (mdev->dev->caps.steering_mode ==
  	    MLX4_STEERING_MODE_DEVICE_MANAGED) {

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

next             reply	other threads:[~2015-02-18  0:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18  0:29 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-12-16  1:41 linux-next: manual merge of the infiniband tree with Linus' tree Stephen Rothwell
2014-10-15  0:46 Stephen Rothwell
2013-02-26  0:45 Stephen Rothwell
2013-02-26  7:27 ` Or Gerlitz
2013-02-22  0:50 Stephen Rothwell
2013-02-22 12:06 ` Or Gerlitz
2012-09-28  1:13 Stephen Rothwell
2012-07-09  2:04 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150218112908.5e2eaee5@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=davem@davemloft$(echo .)net \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=linux-rdma@vger$(echo .)kernel.org \
    --cc=monis@mellanox$(echo .)com \
    --cc=ogerlitz@mellanox$(echo .)com \
    --cc=roland@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox