From: Steven Rostedt <rostedt@goodmis•org>
To: Greg KH <greg@kroah•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Arnd Bergmann <arnd@arndb•de>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Tomas Winkler <tomas.winkler@intel•com>
Subject: Re: linux-next: build warnings after merge of the char-misc tree
Date: Mon, 13 Apr 2015 11:01:01 -0400 [thread overview]
Message-ID: <20150413110101.2aa3c3d0@gandalf.local.home> (raw)
In-Reply-To: <20150413104328.GB6390@kroah.com>
On Mon, 13 Apr 2015 12:43:28 +0200
Greg KH <greg@kroah•com> wrote:
> > In file included from include/trace/define_trace.h:90:0,
> > from drivers/misc/mei/mei-trace.h:76,
> > from drivers/misc/mei/mei-trace.c:21:
> > include/trace/ftrace.h:28:0: note: this is the location of the previous definition
> > #define TRACE_SYSTEM_STRING __app(TRACE_SYSTEM_VAR,__trace_system_name)
> > ^
> >
> > Introduced by commit a0a927d06d79 ("mei: me: add io register tracing")
> > interacting with commit acd388fd3af3 ("tracing: Give system name a
> > pointer") from the ftrace tree.
> >
> > TRACE_SYSTEM_STRING should be removed from drivers/misc/mei/mei-trace.h
> > as it is not being used anywhere in the mei-trace code.
>
> That's nice for such system-wide changes to be done at the last possible
> minute in the development cycle :(
>
Looking at this deeper, this commit isn't a problem with the trace
system change. It is caused probably by a cut and paste from a driver
that had TRACE_SYSTEM_STRING and should not have. A simple removal of
this define should be enough to fix the issue.
-- Steve
next prev parent reply other threads:[~2015-04-13 15:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 9:37 linux-next: build warnings after merge of the char-misc tree Stephen Rothwell
2015-04-13 10:43 ` Greg KH
2015-04-13 10:44 ` Winkler, Tomas
2015-04-13 10:47 ` Stephen Rothwell
2015-04-13 14:17 ` Steven Rostedt
2015-04-13 15:01 ` Steven Rostedt [this message]
2015-04-13 16:07 ` [PATCH] mei: trace: Remove unused TRACE_SYSTEM_STRING define Steven Rostedt
2015-04-13 16:56 ` Greg KH
2015-04-13 13:34 ` linux-next: build warnings after merge of the char-misc tree Greg KH
-- strict thread matches above, loose matches on Subject: below --
2021-01-11 3:42 Stephen Rothwell
2022-11-14 7:17 Stephen Rothwell
2022-11-14 7:33 ` Arnd Bergmann
2022-11-14 9:02 ` Greg KH
2022-11-14 9:03 ` Liu Ying
2022-11-14 9:16 ` Arnd Bergmann
2025-11-14 4:33 Stephen Rothwell
2025-11-14 4:39 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413110101.2aa3c3d0@gandalf.local.home \
--to=rostedt@goodmis$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=greg@kroah$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tomas.winkler@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox