public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: "Eric W. Biederman" <ebiederm@xmission•com>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Subject: linux-next: build failure after merge of the userns tree
Date: Mon, 25 May 2015 20:39:00 +1000	[thread overview]
Message-ID: <20150525203900.4a68a227@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1777 bytes --]

Hi Eric,

After merging the userns tree, today's linux-next build (powerpc allnoconfig)
failed like this:

In file included from include/linux/kobject.h:21:0,
                 from include/linux/device.h:17,
                 from arch/powerpc/include/asm/io.h:27,
                 from arch/powerpc/include/asm/pgtable-ppc32.h:9,
                 from arch/powerpc/include/asm/pgtable.h:19,
                 from include/linux/mm.h:53,
                 from include/linux/pid_namespace.h:6,
                 from include/linux/ptrace.h:8,
                 from arch/powerpc/mm/fault.c:24:
include/linux/sysfs.h: In function 'sysfs_remove_mount_point':
include/linux/sysfs.h:314:2: error: 'return' with a value, in function returning void [-Werror]
  return 0;
  ^

and many more :-(

Caused by commit f7e299595408 ("sysfs: Add support for permanently
empty directories to serve as mount points.").

I have added the following fix patch for today:

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 25 May 2015 20:20:44 +1000
Subject: [PATCH] sysfs: void functions do not return values

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 include/linux/sysfs.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index 3e7e41acc451..9f65758311a4 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -311,7 +311,6 @@ static inline int sysfs_create_mount_point(struct kobject *parent_kobj,
 static inline void sysfs_remove_mount_point(struct kobject *parent_kobj,
 					    const char *name)
 {
-	return 0;
 }
 
 static inline int sysfs_create_file_ns(struct kobject *kobj,
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

             reply	other threads:[~2015-05-25 10:39 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-25 10:39 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-03-16  5:56 linux-next: build failure after merge of the userns tree Stephen Rothwell
2022-03-16 13:54 ` Eric W. Biederman
2021-12-17  7:34 Stephen Rothwell
2021-12-17 16:53 ` Eric W. Biederman
2021-12-17  7:13 Stephen Rothwell
2021-10-20  3:46 Stephen Rothwell
2021-10-20 16:00 ` Eric W. Biederman
2021-10-07  3:47 Stephen Rothwell
2021-10-07 18:56 ` Eric W. Biederman
2020-05-21  8:22 Stephen Rothwell
2018-03-28  7:41 Stephen Rothwell
2018-03-28 18:32 ` Eric W. Biederman
2018-01-26  1:05 Stephen Rothwell
2018-01-26  2:45 ` Eric W. Biederman
2017-07-20  3:25 Stephen Rothwell
2017-07-20 12:17 ` Eric W. Biederman
2014-04-17  5:12 Stephen Rothwell
2014-04-17  7:18 ` Eric W. Biederman
2014-04-22  1:34   ` Stephen Rothwell
2013-11-08  7:07 Stephen Rothwell
2013-11-08 23:15 ` Eric W. Biederman
2013-11-11  5:25   ` Stephen Rothwell
2013-11-08  6:58 Stephen Rothwell
2013-11-08  7:27 ` Christoph Hellwig
2013-11-08 15:55   ` Al Viro
2013-11-08 22:50   ` Eric W. Biederman
2013-11-09  8:32     ` Christoph Hellwig
2012-09-24 12:18 Stephen Rothwell
2012-05-21  7:50 Stephen Rothwell
2012-05-21 22:05 ` Eric W. Biederman
2012-05-14  9:13 Stephen Rothwell
2012-05-16  1:12 ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150525203900.4a68a227@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=ebiederm@xmission$(echo .)com \
    --cc=gregkh@linuxfoundation$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox