Subject: Re: randconfig build error with next-20150528, in drivers/power/twl4030_charger.c

From: Sebastian Reichel <[email-masked]>
Date: Thu, 28 May 2015 22:33:14 +0200

Hi,

On Thu, May 28, 2015 at 01:46:42PM -0500, Felipe Balbi wrote:
> On Thu, May 28, 2015 at 07:57:00PM +0200, Sebastian Reichel wrote:
> > On Thu, May 28, 2015 at 10:05:55AM -0700, Jim Davis wrote:
> > > drivers/power/twl4030_charger.c: In function ‘twl4030_bci_probe’:
> > > drivers/power/twl4030_charger.c:648:23: error: implicit declaration of function
> > > ‘devm_usb_get_phy_by_node’ [-Werror=implicit-function-declaration]
> > >     bci->transceiver = devm_usb_get_phy_by_node(
> > >                        ^
> > > drivers/power/twl4030_charger.c:648:21: warning: assignment makes pointer from i
> > > nteger without a cast [-Wint-conversion]
> > >     bci->transceiver = devm_usb_get_phy_by_node(
> > >                      ^
> > 
> > This has been introduced by the following commit from Neil Brown:
> > 
> > power: twl4030_charger: find associated phy by more reliable means.
> 
> no, this was introduced by the commit which introduced
> devm_usb_get_phy_by_node() (also by Neil) and has already been
> fixed by Arnd.

well without the second patch there would be no devm_usb_get_phy_by_node()
call in twl4030_charger, but no need to go into nitpicking mode :)

> I have the patch in my 'next' branch and it should show up on
> tomorrow's linux-next.

OK, thanks for taking care of this.

-- Sebastian