public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Paul Gortmaker <paul.gortmaker@windriver•com>
To: Thierry Reding <treding@nvidia•com>
Cc: linux-next@vger•kernel.org, linux-arm-kernel@lists•infradead.org
Subject: compile fail with "soc/tegra: fuse: Unify Tegra20 and Tegra30 drivers"
Date: Wed, 3 Jun 2015 12:08:08 -0400	[thread overview]
Message-ID: <20150603160808.GM29898@windriver.com> (raw)

Hi Thierry,

This commit:

  commit 436b6428b9cc97f61721f335eb9d8010751a337e
  Author: Thierry Reding <treding@nvidia•com>
  Date:   Wed Apr 29 16:54:04 2015 +0200

    soc/tegra: fuse: Unify Tegra20 and Tegra30 drivers

in linux-next, in combination with my pending init cleanup

http://marc.info/?l=linux-kernel&m=143327626201054&w=2

will cause a compile fail because 43b642 is relying on an
implicit include of <linux/module.h> to provide the fcn for:

   +module_platform_driver(tegra_fuse_driver);

which in turn causes:

drivers/soc/tegra/fuse/fuse-tegra.c:171:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
drivers/soc/tegra/fuse/fuse-tegra.c:171:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]

Can you add the include to your tree please?  I think it makes
more sense to be there vs. me preemptively adding it to mine.

BTW, I think we can look at converting your driver to use the alternate
fcn builtin_platform_driver later, once that branch is merged.

https://lwn.net/Articles/643854/

Thanks,
Paul.

next             reply	other threads:[~2015-06-03 16:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 16:08 Paul Gortmaker [this message]
2015-06-04  8:49 ` compile fail with "soc/tegra: fuse: Unify Tegra20 and Tegra30 drivers" Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150603160808.GM29898@windriver.com \
    --to=paul.gortmaker@windriver$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=treding@nvidia$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox