From: Herbert Xu <herbert@gondor•apana.org.au>
To: Guenter Roeck <linux@roeck-us•net>
Cc: Stephan Mueller <smueller@chronox•de>,
Peter Zijlstra
<public-peterz-wegcikhe2lqwvfeawa7xhq@plane•gmane.org>,
Andy Shevchenko <andy.shevchenko@gmail•com>,
Jim Davis <jim.epost@gmail•com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Linux-Next <linux-next@vger•kernel.org>,
linux-kernel@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>,
linux-crypto@vger•kernel.org, Waiman Long <waiman.long@hp•com>,
Ingo Molnar <mingo@kernel•org>, x86 <x86@kernel•org>
Subject: nios2: Export get_cycles
Date: Tue, 9 Jun 2015 12:46:46 +0800 [thread overview]
Message-ID: <20150609044646.GA6892@gondor.apana.org.au> (raw)
In-Reply-To: <55766C3A.3070101@roeck-us.net>
On Mon, Jun 08, 2015 at 09:31:54PM -0700, Guenter Roeck wrote:
>
> nios2 still fails to build with
>
> ERROR: "get_cycles" [crypto/jitterentropy.ko] undefined!
It's the only arch that doesn't inline get_cycles and doesn't
export it.
---8<---
nios2 is the only architecture that does not inline get_cycles
and does not export it. This breaks crypto as it uses get_cycles
in a number of modules.
Reported-by: Guenter Roeck <linux@roeck-us•net>
Signed-off-by: Herbert Xu <herbert@gondor•apana.org.au>
diff --git a/arch/nios2/kernel/time.c b/arch/nios2/kernel/time.c
index 7f45474..be186a7 100644
--- a/arch/nios2/kernel/time.c
+++ b/arch/nios2/kernel/time.c
@@ -8,6 +8,7 @@
* for more details.
*/
+#include <linux/export.h>
#include <linux/interrupt.h>
#include <linux/clockchips.h>
#include <linux/clocksource.h>
@@ -106,6 +107,7 @@ cycles_t get_cycles(void)
{
return nios2_timer_read(&nios2_cs.cs);
}
+EXPORT_SYMBOL(get_cycles);
static void nios2_timer_start(struct nios2_timer *timer)
{
--
Email: Herbert Xu <herbert@gondor•apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-06-09 4:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 2:08 [PATCH] crypto: drbg - use pragmas for disabling optimization Stephan Mueller
2015-06-09 3:22 ` Stephen Rothwell
2015-06-09 4:31 ` Guenter Roeck
2015-06-09 4:46 ` Herbert Xu [this message]
2015-06-09 5:19 ` nios2: Export get_cycles Stephen Rothwell
2015-06-09 5:50 ` Herbert Xu
2015-06-09 14:35 ` [PATCH] crypto: drbg - use pragmas for disabling optimization Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609044646.GA6892@gondor.apana.org.au \
--to=herbert@gondor$(echo .)apana.org.au \
--cc=andy.shevchenko@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jim.epost@gmail$(echo .)com \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=mingo@kernel$(echo .)org \
--cc=public-peterz-wegcikhe2lqwvfeawa7xhq@plane$(echo .)gmane.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=smueller@chronox$(echo .)de \
--cc=waiman.long@hp$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox