Subject: Re: [PATCH] crypto: mv_cesa - fix up for of_get_named_gen_pool() rename

From: Herbert Xu <[email-masked]>
Date: Fri, 26 Jun 2015 17:32:54 +0900

On Thu, Jun 25, 2015 at 05:56:05PM +0200, Simon Guinot wrote:
> On Thu, Jun 25, 2015 at 11:30:06PM +0800, Herbert Xu wrote:
> > On Thu, Jun 25, 2015 at 10:37:50AM +0200, Simon Guinot wrote:
> > > This patch fixes the following build error:
> > > 
> > > drivers/crypto/mv_cesa.c: In function 'mv_cesa_get_sram':
> > > drivers/crypto/mv_cesa.c:1037: error: implicit declaration of function 'of_get_named_gen_pool'
> > > drivers/crypto/mv_cesa.c:1038: warning: assignment makes pointer from integer without a cast
> > > scripts/Makefile.build:258: recipe for target 'drivers/crypto/mv_cesa.o' failed
> > > 
> > > Signed-off-by: Simon Guinot <[email-masked]>
> > 
> > This patch doesn't compile.
> 
> It does compile. How it could not ?
> But since the issue has already been fixed, it doesn't really matter.

It breaks the build of mv_cesa in the crypto tree as well as the
cryptodev tree while without your patch the mv_cesa builds just
fine.  If your patch isn't meant for these trees then you should
clearly say so.

Thanks,
-- 
Email: Herbert Xu <[email-masked]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt