From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Rusty Russell <rusty@rustcorp•com.au>
Cc: Dan Streetman <ddstreet@ieee•org>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] modules: elide param_lock if !CONFIG_SYSFS
Date: Fri, 26 Jun 2015 08:39:59 +1000 [thread overview]
Message-ID: <20150626083959.0407ea3c@canb.auug.org.au> (raw)
In-Reply-To: <87616bsd02.fsf@rustcorp.com.au>
[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]
Hi Rusty,
On Fri, 26 Jun 2015 06:48:37 +0930 Rusty Russell <rusty@rustcorp•com.au> wrote:
>
> Dan Streetman <ddstreet@ieee•org> writes:
> > Only include the built-in and per-module param_lock, and corresponding
> > lock/unlock functions, if sysfs is enabled. If there is no sysfs there
> > is no need for locking kernel params.
> >
> > This fixes a build break when CONFIG_SYSFS is not enabled, introduced
> > by commit b51d23e.
>
> This doesn't even come close to applying to my tree?
That's because (as Dan noted) there was another fix patch in the tree
he was fixing ...
> I've fixed it like so, and tested it compiles both with and without
> SYSFS.
>
> Subject: param: fix module param locks when !CONFIG_SYSFS.
>
> As Dan Streetman points out, the entire point of locking for is to
> stop sysfs accesses, so they're elided entirely in the !SYSFS case.
>
> Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
Except the commit you added to the modules tree has no signed off by or
commentary :-(
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-06-25 22:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 6:54 linux-next: build failure after merge of the modules tree Stephen Rothwell
2015-06-25 9:51 ` Dan Streetman
2015-06-25 13:04 ` [PATCH] modules: elide param_lock if !CONFIG_SYSFS Dan Streetman
2015-06-25 21:18 ` Rusty Russell
2015-06-25 21:34 ` Dan Streetman
2015-06-27 0:21 ` Stephen Rothwell
2015-06-28 5:21 ` Rusty Russell
2015-06-25 22:39 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150626083959.0407ea3c@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=ddstreet@ieee$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rusty@rustcorp$(echo .)com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox