public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation•org>
To: Mark Brown <broonie@kernel•org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux•intel.com>,
	Toshi Kani <toshi.kani@hp•com>,
	Matthew Wilcox <willy@linux•intel.com>,
	Catalin Marinas <catalin.marinas@arm•com>,
	Will Deacon <will.deacon@arm•com>,
	kernel-build-reports@lists•linaro.org,
	linaro-kernel@lists•linaro.org, linux-next@vger•kernel.org,
	linux-kernel@vger•kernel.org
Subject: Re: next-20150716 build: 4 failures 88 warnings (next-20150716)
Date: Thu, 16 Jul 2015 14:29:24 -0700	[thread overview]
Message-ID: <20150716142924.2c00bc4c3407e8d0a7918ad7@linux-foundation.org> (raw)
In-Reply-To: <20150716134152.GJ4039@sirena.org.uk>

On Thu, 16 Jul 2015 14:41:52 +0100 Mark Brown <broonie@kernel•org> wrote:

> On Thu, Jul 16, 2015 at 11:05:11AM +0100, Build bot for Mark Brown wrote:
> 
> Today's linux-next fails to build an arm64 allnoconfig due to "mm: make
> GUP handle pfn mapping unless FOLL_GET is requested" which causes:
> 
> > 	arm64-allnoconfig
> > ../mm/gup.c:51:4: error: implicit declaration of function 'update_mmu_cache' [-Werror=implicit-function-declaration]
> 
> The update_mmu_cache() function is defined unconditionally in
> asm/tlbflush.h so there is presumably some path of conditional
> inclusions which causes it not to get declared in an allnoconfig - I
> didn't chase that down yet.

I did te obvious:

--- a/mm/gup.c~mm-make-gup-handle-pfn-mapping-unless-foll_get-is-requested-fix
+++ a/mm/gup.c
@@ -12,7 +12,9 @@
 #include <linux/sched.h>
 #include <linux/rwsem.h>
 #include <linux/hugetlb.h>
+
 #include <asm/pgtable.h>
+#include <asm/tlbflush.h>
 
 #include "internal.h"
 

I don't have arm64 toolchain here, but it fixed the error on arm and
that's what mm/memory.c does.

  parent reply	other threads:[~2015-07-16 21:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 10:05 next-20150716 build: 4 failures 88 warnings (next-20150716) Build bot for Mark Brown
2015-07-16 13:41 ` Mark Brown
2015-07-16 13:48   ` Catalin Marinas
2015-07-16 14:01     ` Mark Brown
2015-07-16 21:29   ` Andrew Morton [this message]
2015-07-16 13:59 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150716142924.2c00bc4c3407e8d0a7918ad7@linux-foundation.org \
    --to=akpm@linux-foundation$(echo .)org \
    --cc=broonie@kernel$(echo .)org \
    --cc=catalin.marinas@arm$(echo .)com \
    --cc=kernel-build-reports@lists$(echo .)linaro.org \
    --cc=kirill.shutemov@linux$(echo .)intel.com \
    --cc=linaro-kernel@lists$(echo .)linaro.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=toshi.kani@hp$(echo .)com \
    --cc=will.deacon@arm$(echo .)com \
    --cc=willy@linux$(echo .)intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox