From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Linus Torvalds <torvalds@linux-foundation•org>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Chris Metcalf <cmetcalf@ezchip•com>,
linuxppc-dev@lists•ozlabs.org
Subject: linux-next: build failure after merge of Linus' tree
Date: Thu, 8 Oct 2015 09:44:44 +1100 [thread overview]
Message-ID: <20151008094444.10d9cc68@canb.auug.org.au> (raw)
Hi Linus,
After merging Linus' tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
lib/string.c: In function 'strscpy':
lib/string.c:209:4: error: implicit declaration of function 'zero_bytemask' [-Werror=implicit-function-declaration]
*(unsigned long *)(dest+res) = c & zero_bytemask(data);
^
Caused by commit
30035e45753b ("string: provide strscpy()")
but only exposed by commit
19c22f3a29fa ("word-at-a-time.h: fix some Kbuild files")
BIG_ENDIAN powerpc doesn't have a definition for this function ...
Isn't this why we have linux-next ... to find this stuff early? :-(
Oh, well, I have applied the following (that just copies zero_bytemask
from asm-generic. I have done no testing beyond compiling.
From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Thu, 8 Oct 2015 09:29:26 +1100
Subject: [PATCH] word-at-a-time.h: powerpc: implement define zero_bytemask
Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
arch/powerpc/include/asm/word-at-a-time.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/include/asm/word-at-a-time.h b/arch/powerpc/include/asm/word-at-a-time.h
index 5b3a903adae6..4f9b6b93c18f 100644
--- a/arch/powerpc/include/asm/word-at-a-time.h
+++ b/arch/powerpc/include/asm/word-at-a-time.h
@@ -40,6 +40,8 @@ static inline bool has_zero(unsigned long val, unsigned long *data, const struct
return (val + c->high_bits) & ~rhs;
}
+#define zero_bytemask(mask) (~1ul << __fls(mask))
+
#else
#ifdef CONFIG_64BIT
--
2.5.1
--
Cheers,
Stephen Rothwell sfr@canb•auug.org.au
next reply other threads:[~2015-10-07 22:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 22:44 Stephen Rothwell [this message]
2015-10-08 0:27 ` [GIT PULL] strscpy powerpc fix for 3.4 Chris Metcalf
2015-10-08 18:45 ` Guenter Roeck
2015-10-08 19:47 ` [GIT PULL] strscpy powerpc fix for 4.3 - not 3.4 :-) Chris Metcalf
2015-10-10 0:39 ` [GIT PULL] strscpy powerpc fix for 3.4 Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2016-08-08 1:58 linux-next: build failure after merge of Linus' tree Stephen Rothwell
2016-08-08 15:37 ` Doug Ledford
2016-08-08 21:53 ` Stephen Rothwell
2016-08-08 23:30 ` Doug Ledford
2016-08-08 23:59 ` Stephen Rothwell
2016-08-09 8:54 ` Leon Romanovsky
2016-08-09 12:45 ` Doug Ledford
2020-04-20 11:35 Stephen Rothwell
2024-09-26 0:04 Stephen Rothwell
2024-09-26 7:36 ` Alice Ryhl
2024-09-26 8:13 ` Stephen Rothwell
2024-09-26 8:24 ` Miguel Ojeda
2024-09-26 12:49 ` Sedat Dilek
2024-09-26 12:58 ` Miguel Ojeda
2024-09-26 14:44 ` Sedat Dilek
2024-09-26 14:57 ` Miguel Ojeda
2025-02-03 1:59 Stephen Rothwell
2025-02-03 2:56 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008094444.10d9cc68@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=cmetcalf@ezchip$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox