Subject: linux-next: build failure after merge of the pinctrl tree

From: Stephen Rothwell <[email-masked]>
Date: Mon, 21 Dec 2015 15:58:11 +1100

Hi Linus,

After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:50: warning: 'struct cygnus_gpio' declared inside parameter list
 static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
                                                  ^
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:50: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_unregister_pinconf':
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:642:25: error: dereferencing pointer to incomplete type 'struct cygnus_gpio'
  pinctrl_unregister(chip->pctl);   
                         ^
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_probe':
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:738:32: warning: passing argument 1 of 'iproc_gpio_unregister_pinconf' from incompatible pointer type [-Wincompatible-pointer-types]   
  iproc_gpio_unregister_pinconf(chip);
                                ^   
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:13: note: expected 'struct cygnus_gpio *' but argument is of type 'struct iproc_gpio *'
 static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
             ^

Caused by commit

 afc8c78d179d ("gpio: Rename func/macro/var to IP-block,iproc")

This does not look like it has even been build tested :-(

I have used the pinctrl tree from next-20151217 again as the previous
(fixed) error was hiding this one.

-- 
Cheers,
Stephen Rothwell                    [email-masked]