From: Andrew Morton <akpm@linux-foundation•org>
To: Mark Brown <broonie@kernel•org>
Cc: Taku Izumi <izumi.taku@jp•fujitsu.com>,
Tony Luck <tony.luck@intel•com>, Mel Gorman <mel@csn•ul.ie>,
Xishi Qiu <qiuxishi@huawei•com>,
Dave Hansen <dave.hansen@intel•com>,
Matt Fleming <matt@codeblueprint•co.uk>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp•fujitsu.com>,
kernel-build-reports@lists•linaro.org,
linux-next@vger•kernel.org, Kevin.Hilman@linaro•org,
Tyler.Baker@linaro•org, linux-arm-kernel@lists•infradead.org,
Russell King <linux@arm•linux.org.uk>
Subject: Re: Widespread boot failures on ARM due to "mm/page_alloc.c: calculate zone_start_pfn at zone_spanned_pages_in_node()"
Date: Mon, 4 Jan 2016 15:09:46 -0800 [thread overview]
Message-ID: <20160104150946.373ed02b8e8b81221340b7c8@linux-foundation.org> (raw)
In-Reply-To: <20160104224233.GU16023@sirena.org.uk>
On Mon, 4 Jan 2016 22:42:33 +0000 Mark Brown <broonie@kernel•org> wrote:
> Since 20151231 -next has been failing to boot on a wide range of ARM
> platforms in the kernelci.org boot tests[1]. Doing bisections with
> Arndale and BeagleBone Black identifies 904769ac82ebf (mm/page_alloc.c:
> calculate zone_start_pfn at zone_spanned_pages_in_node()) from the akpm
> tree as the first broken commit[2,3]. An example bootlog from the
> failure is:
>
> http://storage.kernelci.org/next/next-20151231/arm-multi_v7_defconfig/lab-cambridge/boot-exynos5250-arndale.html
>
> which shows no output on the console once we start the kernel, a brief
> sampling of failing boards suggests this is the normal failure mode.
> x86 and arm64 targets seem fine (juno shows up as failing but the boot
> log seems fine so it's probably a false positive, Mustang was failing
> already) and there are a small number of ARM platforms that boot. I've
> not yet had any time to investigate further than that (including trying
> a revert of that commit), sorry.
>
> [1] http://kernelci.org/boot/all/job/next/kernel/next-20151231/
> [2] https://ci.linaro.org/view/people/job/tbaker-boot-bisect-bot/135/console
> [3] https://ci.linaro.org/view/people/job/tbaker-boot-bisect-bot/136/console
Thanks. That patch has rather a blooper if
CONFIG_HAVE_MEMBLOCK_NODE_MAP=n. Is that the case in your testing?
Arnd's tentative fix is below.
I shall drop that patchset for now.
From: Arnd Bergmann <arnd@arndb•de>
Subject: mm/page_alloc.c: set a zone_start_pfn value in zone_spanned_pages_in_node
We got a new build warning in linux-next:
mm/page_alloc.c: In function 'free_area_init_node':
mm/page_alloc.c:5278:25: warning: 'zone_start_pfn' may be used uninitialized in this function [-Wmaybe-uninitialized]
zone->zone_start_pfn = zone_start_pfn;
mm/page_alloc.c:5265:17: note: 'zone_start_pfn' was declared here
unsigned long zone_start_pfn, zone_end_pfn;
The code indeed looks wrong, but this is just a guess of what the
fix might be: I have not looked it in detail, so please treat this
as a bug report.
Signed-off-by: Arnd Bergmann <arnd@arndb•de>
Cc: Taku Izumi <izumi.taku@jp•fujitsu.com>
Cc: Tony Luck <tony.luck@intel•com>
Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
---
mm/page_alloc.c | 2 ++
1 file changed, 2 insertions(+)
diff -puN mm/page_alloc.c~mm-calculate-zone_start_pfn-at-zone_spanned_pages_in_node-fix mm/page_alloc.c
--- a/mm/page_alloc.c~mm-calculate-zone_start_pfn-at-zone_spanned_pages_in_node-fix
+++ a/mm/page_alloc.c
@@ -5013,6 +5013,8 @@ static inline unsigned long __meminit zo
unsigned long *zone_end_pfn,
unsigned long *zones_size)
{
+ *zone_start_pfn = node_start_pfn;
+ *zone_end_pfn = node_end_pfn;
return zones_size[zone_type];
}
_
next prev parent reply other threads:[~2016-01-04 23:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 22:42 Widespread boot failures on ARM due to "mm/page_alloc.c: calculate zone_start_pfn at zone_spanned_pages_in_node()" Mark Brown
2016-01-04 23:09 ` Andrew Morton [this message]
2016-01-04 23:55 ` Mark Brown
2016-01-05 0:35 ` Andrew Morton
2016-01-05 0:49 ` Stephen Rothwell
2016-01-05 5:47 ` Stephen Rothwell
2016-01-05 5:49 ` Andrew Morton
2016-01-05 11:45 ` Mark Brown
2016-01-05 12:21 ` Sudeep Holla
2016-01-05 19:24 ` Mark Brown
2016-01-05 19:59 ` Steve Capper
2016-01-06 10:32 ` Sudeep Holla
2016-01-06 15:56 ` Steve Capper
2016-01-06 0:22 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104150946.373ed02b8e8b81221340b7c8@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=Kevin.Hilman@linaro$(echo .)org \
--cc=Tyler.Baker@linaro$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=dave.hansen@intel$(echo .)com \
--cc=izumi.taku@jp$(echo .)fujitsu.com \
--cc=kamezawa.hiroyu@jp$(echo .)fujitsu.com \
--cc=kernel-build-reports@lists$(echo .)linaro.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=matt@codeblueprint$(echo .)co.uk \
--cc=mel@csn$(echo .)ul.ie \
--cc=qiuxishi@huawei$(echo .)com \
--cc=tony.luck@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox