From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Josh Poimboeuf <jpoimboe@redhat•com>
Cc: Michael Ellerman <mpe@ellerman•id.au>,
Andrew Morton <akpm@linux-foundation•org>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Arnd Bergmann <arnd@arndb•de>,
Linus Torvalds <torvalds@linux-foundation•org>
Subject: Re: [PATCH] compiler-gcc: require gcc 4.8 for powerpc __builtin_bswap16()
Date: Mon, 9 May 2016 10:59:27 +1000 [thread overview]
Message-ID: <20160509105927.68dfa6d2@canb.auug.org.au> (raw)
In-Reply-To: <20160506142225.rtp2swmdgfzucfjl@treble>
Hi Josh,
On Fri, 6 May 2016 09:22:25 -0500 Josh Poimboeuf <jpoimboe@redhat•com> wrote:
>
> I've also seen no problems on powerpc with 4.4 and 4.8. I suspect it's
> specific to gcc 4.6. Stephen, can you confirm this patch fixes it?
That will obviously fix the problem for us (since it will effectively
restore the code to what it was before the other commit for our gcc
4.6.3 builds and we have not seen it in other builds). I will add this
patch to linux-next today.
And since "byteswap: try to avoid __builtin_constant_p gcc bug" is not
in Linus' tree, hopefully we can have this fix applied soon.
> From: Josh Poimboeuf <jpoimboe@redhat•com>
> Subject: [PATCH] compiler-gcc: require gcc 4.8 for powerpc __builtin_bswap16()
>
> gcc support for __builtin_bswap16() was supposedly added for powerpc in
> gcc 4.6, and was then later added for other architectures in gcc 4.8.
>
> However, Stephen Rothwell reported that attempting to use it on powerpc
> in gcc 4.6 fails with:
>
> lib/vsprintf.c:160:2: error: initializer element is not constant
> lib/vsprintf.c:160:2: error: (near initialization for 'decpair[0]')
> lib/vsprintf.c:160:2: error: initializer element is not constant
> lib/vsprintf.c:160:2: error: (near initialization for 'decpair[1]')
> lib/vsprintf.c:160:2: error: initializer element is not constant
> lib/vsprintf.c:160:2: error: (near initialization for 'decpair[2]')
> lib/vsprintf.c:160:2: error: initializer element is not constant
> lib/vsprintf.c:160:2: error: (near initialization for 'decpair[3]')
> lib/vsprintf.c:160:2: error: initializer element is not constant
>
> I'm not entirely sure what those errors mean, but I don't see them on
> gcc 4.8. So let's consider gcc 4.8 to be the official starting point
> for __builtin_bswap16().
>
> Fixes: 7322dd755e7d ("byteswap: try to avoid __builtin_constant_p gcc bug")
> Reported-by: Stephen Rothwell <sfr@canb•auug.org.au>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat•com>
> ---
> include/linux/compiler-gcc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index eeae401..3d5202e 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -246,7 +246,7 @@
> #define __HAVE_BUILTIN_BSWAP32__
> #define __HAVE_BUILTIN_BSWAP64__
> #endif
> -#if GCC_VERSION >= 40800 || (defined(__powerpc__) && GCC_VERSION >= 40600)
> +#if GCC_VERSION >= 40800
> #define __HAVE_BUILTIN_BSWAP16__
> #endif
> #endif /* CONFIG_ARCH_USE_BUILTIN_BSWAP */
> --
> 2.4.11
--
Cheers,
Stephen Rothwell
next prev parent reply other threads:[~2016-05-09 0:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 4:58 linux-next: build failure after merge of the akpm-current tree Stephen Rothwell
2016-05-06 5:44 ` Andrew Morton
2016-05-06 6:09 ` Stephen Rothwell
2016-05-06 6:55 ` Michael Ellerman
2016-05-06 14:22 ` [PATCH] compiler-gcc: require gcc 4.8 for powerpc __builtin_bswap16() Josh Poimboeuf
2016-05-09 0:59 ` Stephen Rothwell [this message]
2016-05-09 5:39 ` Sedat Dilek
2016-05-09 8:31 ` Stephen Rothwell
2016-05-09 6:33 ` Stephen Rothwell
2016-05-09 9:34 ` Michael Ellerman
2016-05-09 10:16 ` Arnd Bergmann
2016-05-09 10:36 ` Stephen Rothwell
2016-06-15 9:33 ` linux-next: build failure after merge of the akpm-current tree Paul Bolle
2016-06-15 14:03 ` Josh Poimboeuf
2016-06-15 21:12 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509105927.68dfa6d2@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=jpoimboe@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox