From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Arnaldo Carvalho de Melo <acme@redhat•com>
Cc: Andy Lutomirski <luto@amacapital•net>,
Arnaldo Carvalho de Melo <acme@kernel•org>,
Josh Poimboeuf <jpoimboe@redhat•com>,
Peter Zijlstra <peterz@infradead•org>,
Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@kernel•org>, "H. Peter Anvin" <hpa@zytor•com>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH/RFC] Re: linux-next: build failure after merge of the luto-misc tree
Date: Wed, 20 Jul 2016 13:18:14 +1000 [thread overview]
Message-ID: <20160720131814.7fd4abd9@canb.auug.org.au> (raw)
In-Reply-To: <20160720030923.GC2408@redhat.com>
Hi Arnaldo,
On Wed, 20 Jul 2016 00:09:24 -0300 Arnaldo Carvalho de Melo <acme@redhat•com> wrote:
>
> Em Tue, Jul 19, 2016 at 07:57:24PM -0700, Andy Lutomirski escreveu:
> > On Tue, Jul 19, 2016 at 7:52 PM, Arnaldo Carvalho de Melo
> > <acme@kernel•org> wrote:
> > > Em Wed, Jul 20, 2016 at 09:53:33AM +1000, Stephen Rothwell escreveu:
> > >> On Wed, 20 Jul 2016 09:21:57 +1000 Stephen Rothwell <sfr@canb•auug.org.au> wrote:
> > >> > On Tue, 19 Jul 2016 14:45:51 -0300 Arnaldo Carvalho de Melo <acme@kernel•org> wrote:
> > >> > > #if BITS_PER_LONG != __BITS_PER_LONG
> > >> > > +#include <linux/stringify.h>
> > >> > > +#pragma message "BITS_PER_LONG=" __stringify(BITS_PER_LONG)
> > >> > > +#pragma message "__BITS_PER_LONG=" __stringify(__BITS_PER_LONG)
> > >> > > #error Inconsistent word size. Check asm/bitsperlong.h
> > >> > > #endif
> > >
> > >> > I added those three lines to the file (just in yesterday's linux-next
> > >> > was easiest) and got this:
> > >
> > >> > /home/sfr/next/next/tools/include/asm-generic/bitsperlong.h:14:9: note: #pragma message: BITS_PER_LONG=(8 * 8)
> > >> > #pragma message "BITS_PER_LONG=" __stringify(BITS_PER_LONG)
> > >
> > >> > /home/sfr/next/next/tools/include/asm-generic/bitsperlong.h:15:9: note: #pragma message: __BITS_PER_LONG=32
> > >> > #pragma message "__BITS_PER_LONG=" __stringify(__BITS_PER_LONG)
> > >
> > >> > (a few times, of course)
> > >
> > >> So I applied this:
> > >
> > >> +++ b/tools/arch/x86/include/uapi/asm/bitsperlong.h
> > >> @@ -4,6 +4,12 @@
> > >> #if defined(__x86_64__) && !defined(__ILP32__)
> > >> # define __BITS_PER_LONG 64
> > >> #else
> > >> +#ifndef __x86_64__
> > >> +#pragma message "__x86_64__ is not defined"
> > >> +#endif
> > >> +#ifdef __ILP32__
> > >> +#pragma message "__ILP32__ is defined"
> > >> +#endif
> > >> # define __BITS_PER_LONG 32
> > >> #endif
> > >
> > >> and got this:
> > >
> > >> /home/sfr/next/next/tools/arch/x86/include/uapi/asm/bitsperlong.h:8:9: note: #pragma message: __x86_64__ is not defined
> > >> #pragma message "__x86_64__ is not defined"
> > >
> > > Humm, it seems that the compiler used is not the cross one, but the
> > > native, check if, say, __powerpc__ is defined.
> > >
> >
> > This is still vdso2c, right? It's a hostprog.
> >
> > This stuff is utterly screwed up. We're building a hostprog for an
> > x86_64 kernel cross-compiled from powerpc. We should presumably be
> > pullng in powerpc's uapi headers for hostprogs because it's a *host*
> > prog.
>
> Unsure, I thought that what was breaking was objtool (tools/objtool),
> Stephen?
Yes, it is objtool, but that is also a host program and so should be
using the host architectures includes, right? Thanks for pointing that out
Andy,
--
Cheers,
Stephen Rothwell
next prev parent reply other threads:[~2016-07-20 3:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 7:06 linux-next: build failure after merge of the luto-misc tree Stephen Rothwell
2016-07-15 7:22 ` Peter Zijlstra
2016-07-15 7:31 ` Peter Zijlstra
2016-07-15 15:09 ` Arnaldo Carvalho de Melo
2016-07-15 15:24 ` Arnaldo Carvalho de Melo
2016-07-15 15:29 ` Peter Zijlstra
2016-07-15 15:56 ` Arnaldo Carvalho de Melo
2016-07-15 15:43 ` [PATCH/RFC] " Arnaldo Carvalho de Melo
2016-07-15 15:49 ` Peter Zijlstra
2016-07-15 16:28 ` Arnaldo Carvalho de Melo
2016-07-15 20:26 ` H. Peter Anvin
2016-07-18 5:18 ` Stephen Rothwell
2016-07-18 20:04 ` Andy Lutomirski
2016-07-18 20:36 ` Arnaldo Carvalho de Melo
2016-07-18 22:22 ` Stephen Rothwell
2016-07-18 23:41 ` Arnaldo Carvalho de Melo
2016-07-19 0:26 ` Stephen Rothwell
2016-07-19 0:39 ` Arnaldo Carvalho de Melo
2016-07-19 3:26 ` Stephen Rothwell
2016-07-19 12:54 ` Arnaldo Carvalho de Melo
2016-07-19 17:45 ` Arnaldo Carvalho de Melo
2016-07-19 23:21 ` Stephen Rothwell
2016-07-19 23:53 ` Stephen Rothwell
2016-07-20 2:52 ` Arnaldo Carvalho de Melo
2016-07-20 2:57 ` Andy Lutomirski
2016-07-20 3:09 ` Arnaldo Carvalho de Melo
2016-07-20 3:18 ` Stephen Rothwell [this message]
2016-07-20 23:29 ` Stephen Rothwell
2016-07-21 13:12 ` Arnaldo Carvalho de Melo
2016-07-21 23:23 ` Stephen Rothwell
2016-07-22 3:41 ` Josh Poimboeuf
2016-07-22 14:37 ` Arnaldo Carvalho de Melo
2016-07-22 19:19 ` Josh Poimboeuf
2016-07-22 19:36 ` Arnaldo Carvalho de Melo
2016-07-22 19:44 ` Josh Poimboeuf
2016-07-22 19:57 ` Arnaldo Carvalho de Melo
2016-07-23 5:08 ` Stephen Rothwell
2016-07-24 18:40 ` Andy Lutomirski
2016-07-25 12:56 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720131814.7fd4abd9@canb.auug.org.au \
--to=sfr@canb$(echo .)auug.org.au \
--cc=acme@kernel$(echo .)org \
--cc=acme@redhat$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=jpoimboe@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=luto@amacapital$(echo .)net \
--cc=mingo@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox