Subject: Re: [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page

From: Tejun Heo <[email-masked]>
Date: Thu, 21 Jul 2016 17:26:00 -0400

On Fri, Jul 22, 2016 at 02:41:54AM +0800, [email-masked] wrote:
> @@ -3854,6 +3852,8 @@ static unsigned int ata_scsi_mode_select_xlat(struct ata_queued_cmd *qc)
>  		if (ata_mselect_control(qc, p, pg_len, &fp) < 0) {
>  			fp += hdr_len + bd_len;
>  			goto invalid_param;
> +		} else {
> +			goto skip; /* No ATA command to send */

Hmmm... I'm a bit confused.  Why is mselect_control path different
from mselect_caching in terms of qc handling?

Thanks.

-- 
tejun