From: Tejun Heo <tj@kernel•org>
To: tom.ty89@gmail•com
Cc: hare@suse•de, sergei.shtylyov@cogentembedded•com, arnd@arndb•de,
sfr@canb•auug.org.au, linux-ide@vger•kernel.org,
linux-scsi@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-next@vger•kernel.org
Subject: Re: [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page
Date: Tue, 9 Aug 2016 23:38:38 -0400 [thread overview]
Message-ID: <20160810033838.GB25053@mtj.duckdns.org> (raw)
In-Reply-To: <2ed3f3aba21a4b815e9497e6aeba497280f9f333.1469126217.git.tom.ty89@gmail.com>
On Fri, Jul 22, 2016 at 02:41:54AM +0800, tom.ty89@gmail•com wrote:
> From: Tom Yan <tom.ty89@gmail•com>
>
> scsi_done() was called repeatedly and apparently because of that,
> the kernel would call trace when we touch the Control mode page:
>
> Call Trace:
> [<ffffffff812ea0d2>] dump_stack+0x63/0x81
> [<ffffffff81079cfb>] __warn+0xcb/0xf0
> [<ffffffff81079e2d>] warn_slowpath_null+0x1d/0x20
> [<ffffffffa00f51b0>] ata_eh_finish+0xe0/0xf0 [libata]
> [<ffffffffa00fb830>] sata_pmp_error_handler+0x640/0xa50 [libata]
> [<ffffffffa00470ed>] ahci_error_handler+0x1d/0x70 [libahci]
> [<ffffffffa00f55f0>] ata_scsi_port_error_handler+0x430/0x770 [libata]
> [<ffffffffa00eff8d>] ? ata_scsi_cmd_error_handler+0xdd/0x160 [libata]
> [<ffffffffa00f59d7>] ata_scsi_error+0xa7/0xf0 [libata]
> [<ffffffffa00913ba>] scsi_error_handler+0xaa/0x560 [scsi_mod]
> [<ffffffffa0091310>] ? scsi_eh_get_sense+0x180/0x180 [scsi_mod]
> [<ffffffff81098eb8>] kthread+0xd8/0xf0
> [<ffffffff815d913f>] ret_from_fork+0x1f/0x40
> [<ffffffff81098de0>] ? kthread_worker_fn+0x170/0x170
> ---[ end trace 8b7501047e928a17 ]---
>
> Removed the unnecessary code and let ata_scsi_translate() do the job.
>
> Also, since ata_mselect_control() has no ATA command to send to the
> device, ata_scsi_mode_select_xlat() should return 1 for it, so that
> ata_scsi_translate() will finish early to avoid ata_qc_issue().
>
> Signed-off-by: Tom Yan <tom.ty89@gmail•com>
Applied to libata/for-4.9.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-08-10 3:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 18:41 [PATCH resend 1/5] libata-scsi: minor cleanup in ata_mselect_*() tom.ty89
2016-07-21 18:41 ` [PATCH resend 2/5] libata-scsi: fix read-only bits checking " tom.ty89
2016-07-21 18:41 ` [PATCH resend 3/5] libata-scsi: fix overflow in mode page copy tom.ty89
2016-07-21 18:41 ` [PATCH resend 4/5] libata-scsi: have all checks done before calling ata_mselect_*() tom.ty89
2016-07-21 18:41 ` [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page tom.ty89
2016-07-21 21:26 ` Tejun Heo
2016-07-21 21:50 ` Tom Yan
2016-07-25 18:30 ` Tejun Heo
2016-07-27 21:00 ` Tom Yan
2016-08-10 3:38 ` Tejun Heo [this message]
2016-07-21 21:17 ` [PATCH resend 3/5] libata-scsi: fix overflow in mode page copy Tejun Heo
2016-07-21 21:39 ` Tom Yan
2016-07-21 21:42 ` Tejun Heo
[not found] ` <accc8ca07073cd0292b62903acac956f5f5eff74.1469143747.git.tom.ty89@gmail.com>
[not found] ` <9bbf2b818f9ca1bb48f1eae31a0f3924a4fe0d9a.1469143747.git.tom.ty89@gmail.com>
2016-07-21 23:29 ` [PATCH resend v2 3/5] libata-scsi: use u8 array to store " tom.ty89
2016-07-22 9:59 ` Sergei Shtylyov
2016-07-22 18:22 ` Tom Yan
2016-07-22 18:34 ` [PATCH resend v3 " tom.ty89
2016-08-09 20:13 ` Tejun Heo
2016-07-21 23:35 ` [PATCH resend v2 " tom.ty89
2016-07-21 23:20 ` [PATCH resend 2/5] libata-scsi: fix read-only bits checking in ata_mselect_*() Tom Yan
[not found] ` <accc8ca07073cd0292b62903acac956f5f5eff74.1469143271.git.tom.ty89@gmail.com>
2016-07-21 23:25 ` [PATCH resend v2 " tom.ty89
2016-07-21 23:34 ` tom.ty89
2016-07-21 18:45 ` [PATCH resend 1/5] libata-scsi: minor cleanup " Sergei Shtylyov
2016-07-21 18:51 ` Tom Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160810033838.GB25053@mtj.duckdns.org \
--to=tj@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=hare@suse$(echo .)de \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tom.ty89@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox