public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Thomas Gleixner <tglx@linutronix•de>, Ingo Molnar <mingo@elte•hu>,
	"H. Peter Anvin" <hpa@zytor•com>,
	Peter Zijlstra <peterz@infradead•org>
Cc: Linux-Next Mailing List <linux-next@vger•kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
	Evgeny Kalugin <evgeny.kalugin@intel•com>,
	Ard Biesheuvel <ard.biesheuvel@linaro•org>,
	Kees Cook <keescook@chromium•org>
Subject: linux-next: manual merge of the tip tree with the pstore tree
Date: Thu, 6 Apr 2017 12:31:58 +1000	[thread overview]
Message-ID: <20170406123158.7d575f47@canb.auug.org.au> (raw)

Hi all,

Today's linux-next merge of the tip tree got a conflict in:

  drivers/firmware/efi/efi-pstore.c

between commit:

  76cc9580e3fb ("pstore: Replace arguments for write() API")

from the pstore tree and commit:

  fee929ba1c93 ("efi/pstore: Return error code (if any) from efi_pstore_write()")

from the tip tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/firmware/efi/efi-pstore.c
index 93d8cdbe7ef4,6b5acefce6b3..000000000000
--- a/drivers/firmware/efi/efi-pstore.c
+++ b/drivers/firmware/efi/efi-pstore.c
@@@ -254,14 -274,14 +254,14 @@@ static int efi_pstore_write(struct psto
  	for (i = 0; i < DUMP_NAME_LEN; i++)
  		efi_name[i] = name[i];
  
- 	efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,
- 			      !pstore_cannot_block_path(record->reason),
- 			      record->size, record->psi->buf);
+ 	ret = efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,
 -				    !pstore_cannot_block_path(reason),
 -				    size, psi->buf);
++				    !pstore_cannot_block_path(record->reason),
++				    record->size, record->psi->buf);
  
 -	if (reason == KMSG_DUMP_OOPS)
 +	if (record->reason == KMSG_DUMP_OOPS)
  		efivar_run_worker();
  
 -	*id = part;
 +	record->id = record->part;
  	return ret;
  };
  

                 reply	other threads:[~2017-04-06  2:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406123158.7d575f47@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=ard.biesheuvel@linaro$(echo .)org \
    --cc=evgeny.kalugin@intel$(echo .)com \
    --cc=hpa@zytor$(echo .)com \
    --cc=keescook@chromium$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=mingo@elte$(echo .)hu \
    --cc=peterz@infradead$(echo .)org \
    --cc=tglx@linutronix$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox