Subject: Re: [PATCH] staging: rtl8188eu: style fixes

From: Stephen Rothwell <[email-masked]>
Date: Fri, 21 Apr 2017 18:24:49 +1000

Hi Galo,

On Fri, 21 Apr 2017 10:06:25 +0200 Galo <[email-masked]> wrote:
>
> @@ -1461,7 +1460,7 @@ static int rtw_check_join_candidate(struct mlme_priv *pmlmepriv
>  			goto exit;
>  	}
>  
> -	if (*candidate == NULL || (*candidate)->network.Rssi < competitor->network.Rssi) {
> +	if (!candidate || (*candidate)->network.Rssi < competitor->network.Rssi) {

These are not equivalent.  It should be "!*candidate"

-- 
Cheers,
Stephen Rothwell