From: Andrew Morton <akpm@linux-foundation•org>
To: Changwei Ge <ge.changwei@h3c•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Linux-Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Mark Fasheh <mfasheh@versity•com>
Subject: Re: linux-next: build warnings after merge of the akpm-current tree
Date: Fri, 25 Aug 2017 14:23:48 -0700 [thread overview]
Message-ID: <20170825142348.89eb3cf90c2e054869add1d9@linux-foundation.org> (raw)
In-Reply-To: <63ADC13FD55D6546B7DECE290D39E373AC2CF2E2@H3CMLB14-EX.srv.huawei-3com.com>
On Thu, 24 Aug 2017 08:15:30 +0000 Changwei Ge <ge.changwei@h3c•com> wrote:
> Hi Andrew,
>
> On 2017/8/24 15:42, Stephen Rothwell wrote:
> > Hi Andrew, After merging the akpm-current tree, today's linux-next
> > build (x86_64 allmodconfig) produced these warnings:
> > fs/ocfs2/dlm/dlmrecovery.c: In function 'dlm_free_dead_locks':
> > fs/ocfs2/dlm/dlmrecovery.c:2306:6: warning: unused variable 'i'
> > [-Wunused-variable] int i; ^ fs/ocfs2/dlm/dlmrecovery.c:2305:20:
> > warning: unused variable 'queue' [-Wunused-variable] struct list_head
> > *queue = NULL; ^
> My patch never defines these two variables, it's strange that they are
> defined within the patch you collected.
> Could you please help to check if this patch comes from mail '[PATCH]
> ocfs2: re-queue AST or BAST if sending is failed to improve the
> reliability' sent on 7, August.
Yes, I'm not at all sure how those lines got there.
Problem is, the patch you sent was wordwrapped and had its tabs
replaced with spaces. So I had to do quite a lot of work on it to make
it usable. Evidently I somehow added those lines in the process.
Please carefully check that
http://www.ozlabs.org/~akpm/mmotm/broken-out/ocfs2-re-queue-ast-or-bast-if-sending-is-failed-to-improve-the-reliability.patch
plus
--- a/fs/ocfs2/dlm/dlmrecovery.c~ocfs2-re-queue-ast-or-bast-if-sending-is-failed-to-improve-the-reliability-fix
+++ a/fs/ocfs2/dlm/dlmrecovery.c
@@ -2302,8 +2302,6 @@ static void dlm_free_dead_locks(struct d
struct dlm_lock *lock, *next;
unsigned int freed = 0;
int reserved_tmp = 0;
- struct list_head *queue = NULL;
- int i;
/* this node is the lockres master:
* 1) remove any stale locks for the dead node
produce the correct result.
And please appropriately configure your email client for next time!
next prev parent reply other threads:[~2017-08-25 21:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 7:41 linux-next: build warnings after merge of the akpm-current tree Stephen Rothwell
2017-08-24 8:15 ` Changwei Ge
2017-08-25 21:23 ` Andrew Morton [this message]
2017-08-26 1:23 ` Changwei Ge
-- strict thread matches above, loose matches on Subject: below --
2022-02-09 6:02 Stephen Rothwell
2022-02-09 16:03 ` Hugh Dickins
2022-03-28 23:04 ` Matthew Wilcox
2022-03-29 3:32 ` Hugh Dickins
2022-03-24 7:27 ` Stephen Rothwell
2022-03-28 19:54 ` Hugh Dickins
2022-03-28 22:10 ` Matthew Wilcox
2021-10-11 7:31 Stephen Rothwell
2021-10-11 17:46 ` Kees Cook
2021-06-15 10:50 Stephen Rothwell
2020-10-06 12:05 Stephen Rothwell
2020-10-06 20:01 ` Peter Xu
2020-10-06 22:03 ` Stephen Rothwell
2020-01-06 6:14 Stephen Rothwell
2017-03-20 5:22 Stephen Rothwell
2017-03-20 9:05 ` Dmitry Vyukov
2017-03-20 12:30 ` Jan Glauber
2017-03-20 17:06 ` Challa, Mahipal
2015-01-27 8:12 Stephen Rothwell
2015-01-27 8:27 ` Vladimir Davydov
2014-10-03 7:30 Stephen Rothwell
2014-10-03 18:21 ` Andrew Morton
2014-10-03 19:28 ` Michal Nazarewicz
2014-09-23 8:18 Stephen Rothwell
2014-08-26 7:22 Stephen Rothwell
2014-08-26 10:19 ` Xishi Qiu
2013-08-29 9:47 Stephen Rothwell
2013-08-29 11:24 ` Maxim Patlasov
2013-08-29 19:42 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825142348.89eb3cf90c2e054869add1d9@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=ge.changwei@h3c$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mfasheh@versity$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox